[GitHub] [arrow] jorisvandenbossche commented on a diff in pull request #34507: MINOR: [docs] Include `writer.close()` at end of `with ... as writer` calls.

["jorisvandenbossche (via GitHub)" <gi...@apache.org>]

jorisvandenbossche commented on code in PR #34507:
URL: https://github.com/apache/arrow/pull/34507#discussion_r1130566089


##########
docs/source/python/ipc.rst:
##########
@@ -80,6 +80,7 @@ this one can be created with :func:`~pyarrow.ipc.new_stream`:
    with pa.ipc.new_stream(sink, batch.schema) as writer:
       for i in range(5):
          writer.write_batch(batch)
+      writer.close()

Review Comment:
   I think that exiting from the context should call this automatically? (that could also be mentioned in the text to make this explicit)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org