You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Cliff Woolley <cl...@yahoo.com> on 2001/07/27 23:03:23 UTC
Re: cvs commit: httpd-2.0/modules/generators mod_asis.c
On 27 Jul 2001 stoddard@apache.org wrote:
> + b = apr_bucket_file_create(f, 0, (apr_size_t) r->finfo.size, r->pool);
> + APR_BRIGADE_INSERT_TAIL(bb, b);
This is going to need some of OtherBill's and my APR_HAS_LARGE_FILES
magic... I'll take care of it, but it'll have to wait until later. I as
well am out of time for the day.
--Cliff
--------------------------------------------------------------
Cliff Woolley
cliffwoolley@yahoo.com
Charlottesville, VA
Re: cvs commit: httpd-2.0/modules/generators mod_asis.c
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
From: "Bill Stoddard" <bi...@wstoddard.com>
Sent: Friday, July 27, 2001 6:53 PM
> Can't it be handled in the file bucket code?
First, you may have missed the entire apr_size_t v.s. apr_off_t. I realize that
isn't high on anyone's priority list. I happen to be a bit obsessed with seeing
some 72 compiler emits from the build, so I went and fixed them.
You cannot have a single bucket that contains greater than apr_size_t bytes (under the
model I adopted, feel free to replace if you create code that emits no errors and is
functionally correct.) Since apr_bucket_file_create returns one and only one bucket
we would need an apr_brigade_insert_entire_file() function or some nonsense that creates
and tacks on the multiple buckets. It's done in three places, perhaps this isn't such
a bad idea (within apache, not for apr.) Anyone can feel free to implement.
Since apr_sendfile() doesn't send more than apr_size_t bytes, further discussion is
absolutely pointless.
Bill
> From: "Cliff Woolley" <cl...@yahoo.com>
> To: <ne...@apache.org>
> Sent: Friday, July 27, 2001 5:03 PM
> Subject: Re: cvs commit: httpd-2.0/modules/generators mod_asis.c
>
>
> > On 27 Jul 2001 stoddard@apache.org wrote:
> >
> > > + b = apr_bucket_file_create(f, 0, (apr_size_t) r->finfo.size, r->pool);
> > > + APR_BRIGADE_INSERT_TAIL(bb, b);
> >
> > This is going to need some of OtherBill's and my APR_HAS_LARGE_FILES
> > magic... I'll take care of it, but it'll have to wait until later. I as
> > well am out of time for the day.
> >
> > --Cliff
> >
> >
> > --------------------------------------------------------------
> > Cliff Woolley
> > cliffwoolley@yahoo.com
> > Charlottesville, VA
> >
> >
>
>
Re: cvs commit: httpd-2.0/modules/generators mod_asis.c
Posted by Bill Stoddard <bi...@wstoddard.com>.
Can't it be handled in the file bucket code?
Bill
----- Original Message -----
From: "Cliff Woolley" <cl...@yahoo.com>
To: <ne...@apache.org>
Sent: Friday, July 27, 2001 5:03 PM
Subject: Re: cvs commit: httpd-2.0/modules/generators mod_asis.c
> On 27 Jul 2001 stoddard@apache.org wrote:
>
> > + b = apr_bucket_file_create(f, 0, (apr_size_t) r->finfo.size, r->pool);
> > + APR_BRIGADE_INSERT_TAIL(bb, b);
>
> This is going to need some of OtherBill's and my APR_HAS_LARGE_FILES
> magic... I'll take care of it, but it'll have to wait until later. I as
> well am out of time for the day.
>
> --Cliff
>
>
> --------------------------------------------------------------
> Cliff Woolley
> cliffwoolley@yahoo.com
> Charlottesville, VA
>
>