You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by "christogav (via GitHub)" <gi...@apache.org> on 2023/05/20 17:04:59 UTC

[GitHub] [beam] christogav commented on pull request #26042: [Go SDK] Spanner Batched Reads

christogav commented on PR #26042:
URL: https://github.com/apache/beam/pull/26042#issuecomment-1555953305

   @lostluck Thank you so much for the reviews and feedback. I've addressed all feedback.
   
   I've been pondering `ProcessElement` in read_batch.go and the performance impact of re-reading rows across splits. Are there any other different split strategies that might work better or do you think the current approach is ok?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org