[jira] [Resolved] (CSV-140) QuoteMode.NON_NUMERIC doesn't work with CSVPrinter.printRecords(ResultSet)

["Gary Gregory (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CSV-140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Gregory resolved CSV-140.
------------------------------
       Resolution: Fixed
    Fix Version/s: 1.1
         Assignee: Gary Gregory

No need to worry about this kind of performance issue (or not) since the proposed fix is simple and works.

[~damjan] Please verify.

{noformat}
commit -m "[CSV-140] QuoteMode.NON_NUMERIC doesn't work with CSVPrinter.printRecords(ResultSet)" C:/vcs/svn/apache/commons/trunks-proper/csv/src/main/java/org/apache/commons/csv/CSVPrinter.java C:/vcs/svn/apache/commons/trunks-proper/csv/src/changes/changes.xml
    Sending        C:/vcs/svn/apache/commons/trunks-proper/csv/src/changes/changes.xml
    Sending        C:/vcs/svn/apache/commons/trunks-proper/csv/src/main/java/org/apache/commons/csv/CSVPrinter.java
    Transmitting file data ...
    Committed revision 1637781.
{noformat}


> QuoteMode.NON_NUMERIC doesn't work with CSVPrinter.printRecords(ResultSet)
> --------------------------------------------------------------------------
>
>                 Key: CSV-140
>                 URL: https://issues.apache.org/jira/browse/CSV-140
>             Project: Commons CSV
>          Issue Type: Bug
>          Components: Printer
>    Affects Versions: 1.0
>            Reporter: Damjan Jovanovic
>            Assignee: Gary Gregory
>            Priority: Minor
>              Labels: patch
>             Fix For: 1.1
>
>         Attachments: commons-csv-getobject.patch
>
>   Original Estimate: 1m
>  Remaining Estimate: 1m
>
>  CSVPrinter.printRecords(final ResultSet resultSet) retrieves all fields from the ResultSet using ResultSet.getString(), which makes QuoteMode.NON_NUMERIC unnecessarily quote numbers.
> ResultSet.getObject() could be used instead. Any reason why it wasn't?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)