You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/12/12 01:17:48 UTC

[GitHub] [spark] imback82 commented on a change in pull request #30573: [SPARK-26341][WEBUI]Expose executor memory metrics at the stage level, in the Stages tab

imback82 commented on a change in pull request #30573:
URL: https://github.com/apache/spark/pull/30573#discussion_r541466045



##########
File path: core/src/main/scala/org/apache/spark/status/AppStatusListener.scala
##########
@@ -687,6 +687,9 @@ private[spark] class AppStatusListener(
         stage.killedSummary = killedTasksSummary(event.reason, stage.killedSummary)
       }
       stage.activeTasksPerExecutor(event.taskInfo.executorId) -= 1
+
+      stage.executorSummary(event.taskInfo.executorId).peakExecutorMetrics
+        .compareAndUpdatePeakValues(event.taskExecutorMetrics)

Review comment:
       This seems fine to me if we need more accurate peak values.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org