[GitHub] [incubator-dolphinscheduler] felix-thinkingdata commented on a change in pull request #3825: [Improvement-3767][api] Task instance supports query by process instance name

[GitBox <gi...@apache.org>]

felix-thinkingdata commented on a change in pull request #3825:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3825#discussion_r529322270



##########
File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/TaskInstanceController.java
##########
@@ -95,11 +110,20 @@ public Result queryTaskListPaging(@ApiIgnore @RequestAttribute(value = Constants
                                       @RequestParam("pageNo") Integer pageNo,
                                       @RequestParam("pageSize") Integer pageSize) {
 
-        logger.info("query task instance list, project name:{},process instance:{}, search value:{},task name:{}, executor name: {},state type:{}, host:{}, start:{}, end:{}",
-                projectName, processInstanceId, searchVal, taskName, executorName, stateType, host, startTime, endTime);
+        logger.info("query task instance list, projectName:{}, processInstanceId:{}, processInstanceName:{}, search value:{}, taskName:{}, executorName: {}, stateType:{}, host:{}, start:{}, end:{}",
+                StringUtils.replaceNRTtoUnderline(projectName),
+                processInstanceId,
+                StringUtils.replaceNRTtoUnderline(processInstanceName),
+                StringUtils.replaceNRTtoUnderline(searchVal),
+                StringUtils.replaceNRTtoUnderline(taskName),

Review comment:
       if taskName is null ,will throw
    java.lang.NullPointerException: null




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org