You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2018/11/26 21:00:59 UTC
[GitHub] jaydoane commented on a change in pull request #1619: Implement
replicator forced session refresh
jaydoane commented on a change in pull request #1619: Implement replicator forced session refresh
URL: https://github.com/apache/couchdb/pull/1619#discussion_r236416187
##########
File path: src/couch_replicator/src/couch_replicator_auth_session.erl
##########
@@ -79,9 +79,11 @@
-type headers() :: [{string(), string()}].
-type code() :: non_neg_integer().
-type creds() :: {string() | undefined, string() | undefined}.
-
+-type age() :: non_neg_integer() | undefined.
Review comment:
what are the units of `age` when it's not undefined? If it's seconds, could you just do `-type age() :: time_sec() | undefined`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services