You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@quickstep.apache.org by phenyl-sphinx <gi...@git.apache.org> on 2017/11/09 08:23:54 UTC
[GitHub] incubator-quickstep pull request #323: Temporary Build Support for OS X 10.1...
GitHub user phenyl-sphinx opened a pull request:
https://github.com/apache/incubator-quickstep/pull/323
Temporary Build Support for OS X 10.13
Added building support for OS X 10.13 (which didn't work beforehand)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/phenyl-sphinx/incubator-quickstep master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-quickstep/pull/323.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #323
----
commit 2d02669adfaf8cba6f8dee4a6edf2222a82a2a22
Author: Yuanchen Li <yl...@y-l.me>
Date: 2017-11-09T08:18:42Z
Temporary Build Support for OS X 10.13
----
---
[GitHub] incubator-quickstep pull request #323: Temporary Build Support for OS X 10.1...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/323
---
[GitHub] incubator-quickstep issue #323: Temporary Build Support for OS X 10.13
Posted by phenyl-sphinx <gi...@git.apache.org>.
Github user phenyl-sphinx commented on the issue:
https://github.com/apache/incubator-quickstep/pull/323
Squashed
---
[GitHub] incubator-quickstep issue #323: Temporary Build Support for OS X 10.13
Posted by jianqiao <gi...@git.apache.org>.
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/323
LGTM! Can you squash the two commits into one and then I can merge this PR.
(To squash the two commits, go to the repo, `git rebase -i HEAD~2`, change the second `pick` to `fixup`, then save & exit.)
---
[GitHub] incubator-quickstep issue #323: Temporary Build Support for OS X 10.13
Posted by robertclaus <gi...@git.apache.org>.
Github user robertclaus commented on the issue:
https://github.com/apache/incubator-quickstep/pull/323
Sorry, we got our branches mixed up for the 764 project. It's now reverted.
---
[GitHub] incubator-quickstep pull request #323: Temporary Build Support for OS X 10.1...
Posted by phenyl-sphinx <gi...@git.apache.org>.
Github user phenyl-sphinx commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/323#discussion_r150144494
--- Diff: CMakeLists.txt ---
@@ -302,11 +302,11 @@ else()
endif()
endif()
- # OSX 10.12 has deprecated certain system-level APIs which causes protobuf & glog
+ # OSX 10.12+ has deprecated certain system-level APIs which causes protobuf & glog
# builds to fail. As a short-term workaround for now, we turn off deprecated
# warnings so that they do not cause build failures anymore.
# TODO: Remove this workaround by fixing the protobuf_cmake and glog_cmake.
- if (${CMAKE_SYSTEM} MATCHES "Darwin-16.[0-9]*.[0-9]*")
+ if (${CMAKE_SYSTEM} MATCHES "Darwin-1[6-7]*.[0-9]*.[0-9]*")
--- End diff --
No. But either should be able to work.
---
[GitHub] incubator-quickstep issue #323: Temporary Build Support for OS X 10.13
Posted by jianqiao <gi...@git.apache.org>.
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/323
Merged
---
[GitHub] incubator-quickstep issue #323: Temporary Build Support for OS X 10.13
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/323
@robertclaus What's going on?
---
[GitHub] incubator-quickstep pull request #323: Temporary Build Support for OS X 10.1...
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/323#discussion_r150140641
--- Diff: CMakeLists.txt ---
@@ -302,11 +302,11 @@ else()
endif()
endif()
- # OSX 10.12 has deprecated certain system-level APIs which causes protobuf & glog
+ # OSX 10.12+ has deprecated certain system-level APIs which causes protobuf & glog
# builds to fail. As a short-term workaround for now, we turn off deprecated
# warnings so that they do not cause build failures anymore.
# TODO: Remove this workaround by fixing the protobuf_cmake and glog_cmake.
- if (${CMAKE_SYSTEM} MATCHES "Darwin-16.[0-9]*.[0-9]*")
+ if (${CMAKE_SYSTEM} MATCHES "Darwin-1[6-7]*.[0-9]*.[0-9]*")
--- End diff --
Just curious if you have tried `Darwin-1[67].[0-9]*.[0-9]*`? Thanks!
---
[GitHub] incubator-quickstep issue #323: Temporary Build Support for OS X 10.13
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/323
Hi Yuanchen,
Thank you for submitting your PR, and we will test your PR soon.
---