You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/26 08:23:07 UTC
[GitHub] [flink] RocMarshal opened a new pull request #13791: [FLINK-19749][docs] Improve documentation in 'Table API' page
RocMarshal opened a new pull request #13791:
URL: https://github.com/apache/flink/pull/13791
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*Improve documentation in 'Table API' page*
## Brief change log
*Improve documentation in 'Table API' page*
- *MD file location: docs/dev/table/tableAPI.md*
## Verifying this change
*Improve documentation in 'Table API' page*
This change added tests and can be verified as follows:
- *Improve documentation in 'Table API' page*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13791: [FLINK-19749][docs] Improve documentation in 'Table API' page
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13791:
URL: https://github.com/apache/flink/pull/13791#issuecomment-716405856
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9499be668d10c9dfb69de9ba0ceee6fc52aaa82e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8283",
"triggerID" : "9499be668d10c9dfb69de9ba0ceee6fc52aaa82e",
"triggerType" : "PUSH"
}, {
"hash" : "23c16053de3afcbf505b28499fbf03cffaf9b46b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8295",
"triggerID" : "23c16053de3afcbf505b28499fbf03cffaf9b46b",
"triggerType" : "PUSH"
}, {
"hash" : "bb4a09489cc7a59c5b860ade7780670b7d2bcca1",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8421",
"triggerID" : "bb4a09489cc7a59c5b860ade7780670b7d2bcca1",
"triggerType" : "PUSH"
}, {
"hash" : "054cf380741ac078ac258663fa5f118fa413dbc2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8497",
"triggerID" : "054cf380741ac078ac258663fa5f118fa413dbc2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bb4a09489cc7a59c5b860ade7780670b7d2bcca1 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8421)
* 054cf380741ac078ac258663fa5f118fa413dbc2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8497)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13791: [FLINK-19749][docs] Improve documentation in 'Table API' page
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13791:
URL: https://github.com/apache/flink/pull/13791#issuecomment-716405856
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9499be668d10c9dfb69de9ba0ceee6fc52aaa82e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8283",
"triggerID" : "9499be668d10c9dfb69de9ba0ceee6fc52aaa82e",
"triggerType" : "PUSH"
}, {
"hash" : "23c16053de3afcbf505b28499fbf03cffaf9b46b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8295",
"triggerID" : "23c16053de3afcbf505b28499fbf03cffaf9b46b",
"triggerType" : "PUSH"
}, {
"hash" : "bb4a09489cc7a59c5b860ade7780670b7d2bcca1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8421",
"triggerID" : "bb4a09489cc7a59c5b860ade7780670b7d2bcca1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 23c16053de3afcbf505b28499fbf03cffaf9b46b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8295)
* bb4a09489cc7a59c5b860ade7780670b7d2bcca1 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8421)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13791: [FLINK-19749][docs] Improve documentation in 'Table API' page
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13791:
URL: https://github.com/apache/flink/pull/13791#issuecomment-716405856
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9499be668d10c9dfb69de9ba0ceee6fc52aaa82e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8283",
"triggerID" : "9499be668d10c9dfb69de9ba0ceee6fc52aaa82e",
"triggerType" : "PUSH"
}, {
"hash" : "23c16053de3afcbf505b28499fbf03cffaf9b46b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8295",
"triggerID" : "23c16053de3afcbf505b28499fbf03cffaf9b46b",
"triggerType" : "PUSH"
}, {
"hash" : "bb4a09489cc7a59c5b860ade7780670b7d2bcca1",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8421",
"triggerID" : "bb4a09489cc7a59c5b860ade7780670b7d2bcca1",
"triggerType" : "PUSH"
}, {
"hash" : "054cf380741ac078ac258663fa5f118fa413dbc2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "054cf380741ac078ac258663fa5f118fa413dbc2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bb4a09489cc7a59c5b860ade7780670b7d2bcca1 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8421)
* 054cf380741ac078ac258663fa5f118fa413dbc2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13791: [FLINK-19749][docs] Improve documentation in 'Table API' page
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13791:
URL: https://github.com/apache/flink/pull/13791#issuecomment-716392638
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 9499be668d10c9dfb69de9ba0ceee6fc52aaa82e (Mon Oct 26 08:26:07 UTC 2020)
**Warnings:**
* Documentation files were touched, but no `.zh.md` files: Update Chinese documentation or file Jira ticket.
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-19749).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dianfu commented on a change in pull request #13791: [FLINK-19749][docs] Improve documentation in 'Table API' page
Posted by GitBox <gi...@apache.org>.
dianfu commented on a change in pull request #13791:
URL: https://github.com/apache/flink/pull/13791#discussion_r513132764
##########
File path: docs/dev/table/tableApi.zh.md
##########
@@ -24,7 +24,7 @@ under the License.
The Table API is a unified, relational API for stream and batch processing. Table API queries can be run on batch or streaming input without modifications. The Table API is a super set of the SQL language and is specially designed for working with Apache Flink. The Table API is a language-integrated API for Scala, Java and Python. Instead of specifying queries as String values as common with SQL, Table API queries are defined in a language-embedded style in Java, Scala or Python with IDE support like autocompletion and syntax validation.
-The Table API shares many concepts and parts of its API with Flink's SQL integration. Have a look at the [Common Concepts & API]({{ site.baseurl }}/dev/table/common.html) to learn how to register tables or to create a `Table` object. The [Streaming Concepts](./streaming) pages discuss streaming specific concepts such as dynamic tables and time attributes.
+The Table API shares many concepts and parts of its API with Flink's SQL integration. Have a look at the [Common Concepts & API]({% link dev/table/common.md %}) to learn how to register tables or to create a `Table` object. The [Streaming Concepts](./streaming) pages discuss streaming specific concepts such as dynamic tables and time attributes.
Review comment:
```suggestion
The Table API shares many concepts and parts of its API with Flink's SQL integration. Have a look at the [Common Concepts & API]({% link dev/table/common.zh.md %}) to learn how to register tables or to create a `Table` object. The [Streaming Concepts](./streaming) pages discuss streaming specific concepts such as dynamic tables and time attributes.
```
Same for the other places.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RocMarshal commented on a change in pull request #13791: [FLINK-19749][docs] Improve documentation in 'Table API' page
Posted by GitBox <gi...@apache.org>.
RocMarshal commented on a change in pull request #13791:
URL: https://github.com/apache/flink/pull/13791#discussion_r514889039
##########
File path: docs/dev/table/tableApi.zh.md
##########
@@ -477,11 +477,11 @@ val result = orders.where($"b" === "red")
<tbody>
<tr>
<td>
- <strong>From</strong><br>
- <span class="label label-primary">批处理</span> <span class="label label-primary">流处理</span>
+ <strong>FromPath</strong><br>
+ <span class="label label-primary">Batch</span> <span class="label label-primary">Streaming</span>
Review comment:
```suggestion
<span class="label label-primary">批处理</span> <span class="label label-primary">流处理</span>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13791: [FLINK-19749][docs] Improve documentation in 'Table API' page
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13791:
URL: https://github.com/apache/flink/pull/13791#issuecomment-716405856
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9499be668d10c9dfb69de9ba0ceee6fc52aaa82e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9499be668d10c9dfb69de9ba0ceee6fc52aaa82e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9499be668d10c9dfb69de9ba0ceee6fc52aaa82e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13791: [FLINK-19749][docs] Improve documentation in 'Table API' page
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13791:
URL: https://github.com/apache/flink/pull/13791#issuecomment-716405856
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9499be668d10c9dfb69de9ba0ceee6fc52aaa82e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8283",
"triggerID" : "9499be668d10c9dfb69de9ba0ceee6fc52aaa82e",
"triggerType" : "PUSH"
}, {
"hash" : "23c16053de3afcbf505b28499fbf03cffaf9b46b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8295",
"triggerID" : "23c16053de3afcbf505b28499fbf03cffaf9b46b",
"triggerType" : "PUSH"
}, {
"hash" : "bb4a09489cc7a59c5b860ade7780670b7d2bcca1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bb4a09489cc7a59c5b860ade7780670b7d2bcca1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 23c16053de3afcbf505b28499fbf03cffaf9b46b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8295)
* bb4a09489cc7a59c5b860ade7780670b7d2bcca1 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13791: [FLINK-19749][docs] Improve documentation in 'Table API' page
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13791:
URL: https://github.com/apache/flink/pull/13791#issuecomment-716405856
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9499be668d10c9dfb69de9ba0ceee6fc52aaa82e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8283",
"triggerID" : "9499be668d10c9dfb69de9ba0ceee6fc52aaa82e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9499be668d10c9dfb69de9ba0ceee6fc52aaa82e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8283)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13791: [FLINK-19749][docs] Improve documentation in 'Table API' page
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13791:
URL: https://github.com/apache/flink/pull/13791#issuecomment-716405856
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9499be668d10c9dfb69de9ba0ceee6fc52aaa82e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8283",
"triggerID" : "9499be668d10c9dfb69de9ba0ceee6fc52aaa82e",
"triggerType" : "PUSH"
}, {
"hash" : "23c16053de3afcbf505b28499fbf03cffaf9b46b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8295",
"triggerID" : "23c16053de3afcbf505b28499fbf03cffaf9b46b",
"triggerType" : "PUSH"
}, {
"hash" : "bb4a09489cc7a59c5b860ade7780670b7d2bcca1",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8421",
"triggerID" : "bb4a09489cc7a59c5b860ade7780670b7d2bcca1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bb4a09489cc7a59c5b860ade7780670b7d2bcca1 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8421)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13791: [FLINK-19749][docs] Improve documentation in 'Table API' page
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13791:
URL: https://github.com/apache/flink/pull/13791#issuecomment-716405856
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9499be668d10c9dfb69de9ba0ceee6fc52aaa82e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8283",
"triggerID" : "9499be668d10c9dfb69de9ba0ceee6fc52aaa82e",
"triggerType" : "PUSH"
}, {
"hash" : "23c16053de3afcbf505b28499fbf03cffaf9b46b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8295",
"triggerID" : "23c16053de3afcbf505b28499fbf03cffaf9b46b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9499be668d10c9dfb69de9ba0ceee6fc52aaa82e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8283)
* 23c16053de3afcbf505b28499fbf03cffaf9b46b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8295)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RocMarshal commented on pull request #13791: [FLINK-19749][docs] Improve documentation in 'Table API' page
Posted by GitBox <gi...@apache.org>.
RocMarshal commented on pull request #13791:
URL: https://github.com/apache/flink/pull/13791#issuecomment-719124986
ping @dianfu @wuchong
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RocMarshal commented on a change in pull request #13791: [FLINK-19749][docs] Improve documentation in 'Table API' page
Posted by GitBox <gi...@apache.org>.
RocMarshal commented on a change in pull request #13791:
URL: https://github.com/apache/flink/pull/13791#discussion_r514890320
##########
File path: docs/dev/table/tableApi.zh.md
##########
@@ -477,11 +477,11 @@ val result = orders.where($"b" === "red")
<tbody>
<tr>
<td>
- <strong>From</strong><br>
- <span class="label label-primary">批处理</span> <span class="label label-primary">流处理</span>
+ <strong>FromPath</strong><br>
+ <span class="label label-primary">Batch</span> <span class="label label-primary">Streaming</span>
Review comment:
@dianfu So sorry for this issue.
Thank you for your reminder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13791: [FLINK-19749][docs] Improve documentation in 'Table API' page
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13791:
URL: https://github.com/apache/flink/pull/13791#issuecomment-716405856
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9499be668d10c9dfb69de9ba0ceee6fc52aaa82e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8283",
"triggerID" : "9499be668d10c9dfb69de9ba0ceee6fc52aaa82e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9499be668d10c9dfb69de9ba0ceee6fc52aaa82e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8283)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13791: [FLINK-19749][docs] Improve documentation in 'Table API' page
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13791:
URL: https://github.com/apache/flink/pull/13791#issuecomment-716405856
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9499be668d10c9dfb69de9ba0ceee6fc52aaa82e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8283",
"triggerID" : "9499be668d10c9dfb69de9ba0ceee6fc52aaa82e",
"triggerType" : "PUSH"
}, {
"hash" : "23c16053de3afcbf505b28499fbf03cffaf9b46b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "23c16053de3afcbf505b28499fbf03cffaf9b46b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9499be668d10c9dfb69de9ba0ceee6fc52aaa82e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8283)
* 23c16053de3afcbf505b28499fbf03cffaf9b46b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dianfu closed pull request #13791: [FLINK-19749][docs] Improve documentation in 'Table API' page
Posted by GitBox <gi...@apache.org>.
dianfu closed pull request #13791:
URL: https://github.com/apache/flink/pull/13791
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dianfu commented on a change in pull request #13791: [FLINK-19749][docs] Improve documentation in 'Table API' page
Posted by GitBox <gi...@apache.org>.
dianfu commented on a change in pull request #13791:
URL: https://github.com/apache/flink/pull/13791#discussion_r514771411
##########
File path: docs/dev/table/tableApi.zh.md
##########
@@ -477,11 +477,11 @@ val result = orders.where($"b" === "red")
<tbody>
<tr>
<td>
- <strong>From</strong><br>
- <span class="label label-primary">批处理</span> <span class="label label-primary">流处理</span>
+ <strong>FromPath</strong><br>
+ <span class="label label-primary">Batch</span> <span class="label label-primary">Streaming</span>
Review comment:
why change this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13791: [FLINK-19749][docs] Improve documentation in 'Table API' page
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13791:
URL: https://github.com/apache/flink/pull/13791#issuecomment-716405856
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9499be668d10c9dfb69de9ba0ceee6fc52aaa82e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8283",
"triggerID" : "9499be668d10c9dfb69de9ba0ceee6fc52aaa82e",
"triggerType" : "PUSH"
}, {
"hash" : "23c16053de3afcbf505b28499fbf03cffaf9b46b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8295",
"triggerID" : "23c16053de3afcbf505b28499fbf03cffaf9b46b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 23c16053de3afcbf505b28499fbf03cffaf9b46b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8295)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RocMarshal commented on pull request #13791: [FLINK-19749][docs] Improve documentation in 'Table API' page
Posted by GitBox <gi...@apache.org>.
RocMarshal commented on pull request #13791:
URL: https://github.com/apache/flink/pull/13791#issuecomment-717286076
@dianfu
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13791: [FLINK-19749][docs] Improve documentation in 'Table API' page
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13791:
URL: https://github.com/apache/flink/pull/13791#issuecomment-716405856
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9499be668d10c9dfb69de9ba0ceee6fc52aaa82e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8283",
"triggerID" : "9499be668d10c9dfb69de9ba0ceee6fc52aaa82e",
"triggerType" : "PUSH"
}, {
"hash" : "23c16053de3afcbf505b28499fbf03cffaf9b46b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8295",
"triggerID" : "23c16053de3afcbf505b28499fbf03cffaf9b46b",
"triggerType" : "PUSH"
}, {
"hash" : "bb4a09489cc7a59c5b860ade7780670b7d2bcca1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8421",
"triggerID" : "bb4a09489cc7a59c5b860ade7780670b7d2bcca1",
"triggerType" : "PUSH"
}, {
"hash" : "054cf380741ac078ac258663fa5f118fa413dbc2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8497",
"triggerID" : "054cf380741ac078ac258663fa5f118fa413dbc2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 054cf380741ac078ac258663fa5f118fa413dbc2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8497)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RocMarshal commented on pull request #13791: [FLINK-19749][docs] Improve documentation in 'Table API' page
Posted by GitBox <gi...@apache.org>.
RocMarshal commented on pull request #13791:
URL: https://github.com/apache/flink/pull/13791#issuecomment-716940547
ping @dianfu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RocMarshal commented on a change in pull request #13791: [FLINK-19749][docs] Improve documentation in 'Table API' page
Posted by GitBox <gi...@apache.org>.
RocMarshal commented on a change in pull request #13791:
URL: https://github.com/apache/flink/pull/13791#discussion_r513201162
##########
File path: docs/dev/table/tableApi.zh.md
##########
@@ -3172,7 +3176,7 @@ Table table = input
</td>
<td>
<p>Similar to a <b>GroupBy Aggregation</b>. Groups the rows on the grouping keys with the following running table aggregation operator to aggregate rows group-wise. The difference from an AggregateFunction is that TableAggregateFunction may return 0 or more records for a group. You have to close the "flatAggregate" with a select statement. And the select statement does not support aggregate functions.</p>
- <p>Instead of using <code>emitValue</code> to output results, you can also use the <code>emitUpdateWithRetract</code> method. Different from <code>emitValue</code>, <code>emitUpdateWithRetract</code> is used to emit values that have been updated. This method outputs data incrementally in retract mode, i.e., once there is an update, we have to retract old records before sending new updated ones. The <code>emitUpdateWithRetract</code> method will be used in preference to the <code>emitValue</code> method if both methods are defined in the table aggregate function, because the method is treated to be more efficient than <code>emitValue</code> as it can output values incrementally. See <a href="{{ site.baseurl }}/dev/table/functions/udfs.html#table-aggregation-functions">Table Aggregation Functions</a> for details.</p>
+ <p>Instead of using <code>emitValue</code> to output results, you can also use the <code>emitUpdateWithRetract</code> method. Different from <code>emitValue</code>, <code>emitUpdateWithRetract</code> is used to emit values that have been updated. This method outputs data incrementally in retract mode, i.e., once there is an update, we have to retract old records before sending new updated ones. The <code>emitUpdateWithRetract</code> method will be used in preference to the <code>emitValue</code> method if both methods are defined in the table aggregate function, because the method is treated to be more efficient than <code>emitValue</code> as it can output values incrementally. See <a href="{% link dev/table/functions/udfs.md %}#table-aggregation-functions">Table Aggregation Functions</a> for details.</p>
Review comment:
```suggestion
<p>Instead of using <code>emitValue</code> to output results, you can also use the <code>emitUpdateWithRetract</code> method. Different from <code>emitValue</code>, <code>emitUpdateWithRetract</code> is used to emit values that have been updated. This method outputs data incrementally in retract mode, i.e., once there is an update, we have to retract old records before sending new updated ones. The <code>emitUpdateWithRetract</code> method will be used in preference to the <code>emitValue</code> method if both methods are defined in the table aggregate function, because the method is treated to be more efficient than <code>emitValue</code> as it can output values incrementally. See <a href="{% link dev/table/functions/udfs.zh.md %}#table-aggregation-functions">Table Aggregation Functions</a> for details.</p>
```
##########
File path: docs/dev/table/tableApi.zh.md
##########
@@ -3571,9 +3575,9 @@ Please see the dedicated page about [data types](types.html).
Generic types and (nested) composite types (e.g., POJOs, tuples, rows, Scala case classes) can be fields of a row as well.
-Fields of composite types with arbitrary nesting can be accessed with [value access functions]({{ site.baseurl }}/dev/table/functions/systemFunctions.html#value-access-functions).
+Fields of composite types with arbitrary nesting can be accessed with [value access functions]({% link dev/table/functions/systemFunctions.md %}#value-access-functions).
-Generic types are treated as a black box and can be passed on or processed by [user-defined functions]({{ site.baseurl }}/dev/table/functions/udfs.html).
+Generic types are treated as a black box and can be passed on or processed by [user-defined functions]({% link dev/table/functions/udfs.md %}).
Review comment:
```suggestion
Generic types are treated as a black box and can be passed on or processed by [user-defined functions]({% link dev/table/functions/udfs.zh.md %}).
```
##########
File path: docs/dev/table/tableApi.zh.md
##########
@@ -3571,9 +3575,9 @@ Please see the dedicated page about [data types](types.html).
Generic types and (nested) composite types (e.g., POJOs, tuples, rows, Scala case classes) can be fields of a row as well.
-Fields of composite types with arbitrary nesting can be accessed with [value access functions]({{ site.baseurl }}/dev/table/functions/systemFunctions.html#value-access-functions).
+Fields of composite types with arbitrary nesting can be accessed with [value access functions]({% link dev/table/functions/systemFunctions.md %}#value-access-functions).
Review comment:
```suggestion
Fields of composite types with arbitrary nesting can be accessed with [value access functions]({% link dev/table/functions/systemFunctions.zh.md %}#value-access-functions).
```
##########
File path: docs/dev/table/tableApi.zh.md
##########
@@ -3398,7 +3402,7 @@ val table = input
</td>
<td>
<p>Similar to a <b>GroupBy Aggregation</b>. Groups the rows on the grouping keys with the following running table aggregation operator to aggregate rows group-wise. The difference from an AggregateFunction is that TableAggregateFunction may return 0 or more records for a group. You have to close the "flatAggregate" with a select statement. And the select statement does not support aggregate functions.</p>
- <p>Instead of using <code>emitValue</code> to output results, you can also use the <code>emitUpdateWithRetract</code> method. Different from <code>emitValue</code>, <code>emitUpdateWithRetract</code> is used to emit values that have been updated. This method outputs data incrementally in retract mode, i.e., once there is an update, we have to retract old records before sending new updated ones. The <code>emitUpdateWithRetract</code> method will be used in preference to the <code>emitValue</code> method if both methods are defined in the table aggregate function, because the method is treated to be more efficient than <code>emitValue</code> as it can output values incrementally. See <a href="{{ site.baseurl }}/dev/table/functions/udfs.html#table-aggregation-functions">Table Aggregation Functions</a> for details.</p>
+ <p>Instead of using <code>emitValue</code> to output results, you can also use the <code>emitUpdateWithRetract</code> method. Different from <code>emitValue</code>, <code>emitUpdateWithRetract</code> is used to emit values that have been updated. This method outputs data incrementally in retract mode, i.e., once there is an update, we have to retract old records before sending new updated ones. The <code>emitUpdateWithRetract</code> method will be used in preference to the <code>emitValue</code> method if both methods are defined in the table aggregate function, because the method is treated to be more efficient than <code>emitValue</code> as it can output values incrementally. See <a href="{% link dev/table/functions/udfs.md %}#table-aggregation-functions">Table Aggregation Functions</a> for details.</p>
Review comment:
```suggestion
<p>Instead of using <code>emitValue</code> to output results, you can also use the <code>emitUpdateWithRetract</code> method. Different from <code>emitValue</code>, <code>emitUpdateWithRetract</code> is used to emit values that have been updated. This method outputs data incrementally in retract mode, i.e., once there is an update, we have to retract old records before sending new updated ones. The <code>emitUpdateWithRetract</code> method will be used in preference to the <code>emitValue</code> method if both methods are defined in the table aggregate function, because the method is treated to be more efficient than <code>emitValue</code> as it can output values incrementally. See <a href="{% link dev/table/functions/udfs.zh.md %}#table-aggregation-functions">Table Aggregation Functions</a> for details.</p>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org