You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Zhitao Li <zh...@gmail.com> on 2016/11/28 19:26:20 UTC

Review Request 53993: Updated quota doc to support quota update.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53993/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov and Xiaojian Huang.


Bugs: MESOS-4941
    https://issues.apache.org/jira/browse/MESOS-4941


Repository: mesos


Description
-------

Updated quota doc to support quota update.


Diffs
-----

  docs/quota.md d7e8d58eeeac9d9ffc1a6f7614c7ddce6d7a9b89 

Diff: https://reviews.apache.org/r/53993/diff/


Testing
-------

https://github.com/zhitaoli/mesos/blob/quota_update_sept/docs/quota.md


Thanks,

Zhitao Li

Re: Review Request 53993: Updated quota doc to support quota update.

Posted by haosdent huang <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53993/#review163094
-----------------------------------------------------------



May you mind add @neilc in reviewers?


docs/quota.md (line 85)
<https://reviews.apache.org/r/53993/#comment234536>

    `Updating`


- haosdent huang


On Nov. 28, 2016, 7:26 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53993/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2016, 7:26 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Xiaojian Huang.
> 
> 
> Bugs: MESOS-4941
>     https://issues.apache.org/jira/browse/MESOS-4941
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated quota doc to support quota update.
> 
> 
> Diffs
> -----
> 
>   docs/quota.md d7e8d58eeeac9d9ffc1a6f7614c7ddce6d7a9b89 
> 
> Diff: https://reviews.apache.org/r/53993/diff/
> 
> 
> Testing
> -------
> 
> https://github.com/zhitaoli/mesos/blob/quota_update_sept/docs/quota.md
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 53993: Updated quota doc to support quota update.

Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53993/
-----------------------------------------------------------

(Updated Feb. 7, 2017, 7:15 a.m.)


Review request for mesos, Alexander Rukletsov and Xiaojian Huang.


Changes
-------

Rebase and review comments.


Bugs: MESOS-4941
    https://issues.apache.org/jira/browse/MESOS-4941


Repository: mesos


Description
-------

Updated quota doc to support quota update.


Diffs (updated)
-----

  docs/quota.md 36b4853b524ba7b28788fe1f3983dd43d95072d4 

Diff: https://reviews.apache.org/r/53993/diff/


Testing
-------

https://github.com/zhitaoli/mesos/blob/quota_update_sept/docs/quota.md


Thanks,

Zhitao Li

Re: Review Request 53993: Updated quota doc to support quota update.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53993/#review163120
-----------------------------------------------------------



Bad patch!

Reviews applied: [53993, 54135, 53991, 52103, 53691, 53679, 52284]

Failed command: python support/apply-reviews.py -n -r 52103

Error:
2017-01-26 11:06:12 URL:https://reviews.apache.org/r/52103/diff/raw/ [27771/27771] -> "52103.patch" [1]
error: patch failed: src/master/quota_handler.cpp:130
error: src/master/quota_handler.cpp: patch does not apply

Full log: https://builds.apache.org/job/Mesos-Reviewbot/16861/console

- Mesos Reviewbot


On Nov. 28, 2016, 7:26 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53993/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2016, 7:26 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Xiaojian Huang.
> 
> 
> Bugs: MESOS-4941
>     https://issues.apache.org/jira/browse/MESOS-4941
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated quota doc to support quota update.
> 
> 
> Diffs
> -----
> 
>   docs/quota.md d7e8d58eeeac9d9ffc1a6f7614c7ddce6d7a9b89 
> 
> Diff: https://reviews.apache.org/r/53993/diff/
> 
> 
> Testing
> -------
> 
> https://github.com/zhitaoli/mesos/blob/quota_update_sept/docs/quota.md
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>