[GitHub] [arrow-datafusion] thinkharderdev commented on a change in pull request #2111: Introduce datafusion-objectstore-hdfs as optional features in the datafusion core

[GitBox <gi...@apache.org>]

thinkharderdev commented on a change in pull request #2111:
URL: https://github.com/apache/arrow-datafusion/pull/2111#discussion_r839383936



##########
File path: datafusion/core/Cargo.toml
##########
@@ -60,9 +62,10 @@ async-trait = "0.1.41"
 avro-rs = { version = "0.13", features = ["snappy"], optional = true }
 chrono = { version = "0.4", default-features = false }
 datafusion-common = { path = "../common", version = "7.0.0", features = ["parquet"] }
-datafusion-data-access = { path = "../../data-access", version = "1.0.0" }
+datafusion-data-access = { git = "https://github.com/apache/arrow-datafusion.git", rev = "41b4e491663029f653e491b110d0b5e74d08a0b6" }

Review comment:
       Isn't `datafusion-data-access` a core part of datfusion though. The `ObjectStore` trait is baked in everywhere. It seems a bit weird to move that into a contrib module. 
   
   Would it be possible to leverage something like https://github.com/apache/arrow-datafusion/pull/1881 to load contrib `ObjectStores` as plugins?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org