You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@accumulo.apache.org by ct...@apache.org on 2022/11/02 21:53:11 UTC
[accumulo] branch 2.1 updated: Fix resource leak warning
This is an automated email from the ASF dual-hosted git repository.
ctubbsii pushed a commit to branch 2.1
in repository https://gitbox.apache.org/repos/asf/accumulo.git
The following commit(s) were added to refs/heads/2.1 by this push:
new a04c41612f Fix resource leak warning
a04c41612f is described below
commit a04c41612f7bc1bd4d00570595a7220a4b0c43b6
Author: Christopher Tubbs <ct...@apache.org>
AuthorDate: Wed Nov 2 17:51:59 2022 -0400
Fix resource leak warning
Fix resource leak warning introduced in #3059
---
.../coordinator/CompactionCoordinatorTest.java | 30 ++++++++++++----------
1 file changed, 16 insertions(+), 14 deletions(-)
diff --git a/server/compaction-coordinator/src/test/java/org/apache/accumulo/coordinator/CompactionCoordinatorTest.java b/server/compaction-coordinator/src/test/java/org/apache/accumulo/coordinator/CompactionCoordinatorTest.java
index f2c57358d1..7f46d68e7f 100644
--- a/server/compaction-coordinator/src/test/java/org/apache/accumulo/coordinator/CompactionCoordinatorTest.java
+++ b/server/compaction-coordinator/src/test/java/org/apache/accumulo/coordinator/CompactionCoordinatorTest.java
@@ -165,6 +165,7 @@ public class CompactionCoordinatorTest {
metadataCompactionIds = mci;
}
+ @Override
protected Set<ExternalCompactionId> readExternalCompactionIds() {
if (metadataCompactionIds == null) {
return RUNNING_CACHE.keySet();
@@ -626,26 +627,27 @@ public class CompactionCoordinatorTest {
PowerMock.replayAll();
- var coordinator = new TestCoordinator(finalizer, tservers, client, tsc, context, security);
- coordinator.resetInternals();
+ try (var coordinator =
+ new TestCoordinator(finalizer, tservers, client, tsc, context, security)) {
+ coordinator.resetInternals();
- var ecid1 = ExternalCompactionId.generate(UUID.randomUUID());
- var ecid2 = ExternalCompactionId.generate(UUID.randomUUID());
- var ecid3 = ExternalCompactionId.generate(UUID.randomUUID());
+ var ecid1 = ExternalCompactionId.generate(UUID.randomUUID());
+ var ecid2 = ExternalCompactionId.generate(UUID.randomUUID());
+ var ecid3 = ExternalCompactionId.generate(UUID.randomUUID());
- coordinator.getRunning().put(ecid1, new RunningCompaction(new TExternalCompaction()));
- coordinator.getRunning().put(ecid2, new RunningCompaction(new TExternalCompaction()));
- coordinator.getRunning().put(ecid3, new RunningCompaction(new TExternalCompaction()));
+ coordinator.getRunning().put(ecid1, new RunningCompaction(new TExternalCompaction()));
+ coordinator.getRunning().put(ecid2, new RunningCompaction(new TExternalCompaction()));
+ coordinator.getRunning().put(ecid3, new RunningCompaction(new TExternalCompaction()));
- coordinator.cleanUpRunning();
+ coordinator.cleanUpRunning();
- assertEquals(Set.of(ecid1, ecid2, ecid3), coordinator.getRunning().keySet());
+ assertEquals(Set.of(ecid1, ecid2, ecid3), coordinator.getRunning().keySet());
- coordinator.setMetadataCompactionIds(Set.of(ecid1, ecid2));
+ coordinator.setMetadataCompactionIds(Set.of(ecid1, ecid2));
- coordinator.cleanUpRunning();
-
- assertEquals(Set.of(ecid1, ecid2), coordinator.getRunning().keySet());
+ coordinator.cleanUpRunning();
+ assertEquals(Set.of(ecid1, ecid2), coordinator.getRunning().keySet());
+ }
}
}