You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/12/06 23:19:55 UTC

[GitHub] [maven-jlink-plugin] elharo commented on a change in pull request #23: [MJLINK-57] Migrate to slf4j

elharo commented on a change in pull request #23:
URL: https://github.com/apache/maven-jlink-plugin/pull/23#discussion_r537147596



##########
File path: src/main/java/org/apache/maven/plugins/jlink/AbstractJLinkToolchainExecutor.java
##########
@@ -35,11 +36,11 @@
 
 abstract class AbstractJLinkToolchainExecutor extends AbstractJLinkExecutor
 {
+    private static final Logger LOGGER = LoggerFactory.getLogger( AbstractJLinkToolchainExecutor.class );

Review comment:
       usually "logger" because the object isn't truly a constant even if the variable is




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org