You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "Farhantigadi (via GitHub)" <gi...@apache.org> on 2026/01/07 15:04:28 UTC

[PR] Add input validation to split-tests.sh script [fineract]

Farhantigadi opened a new pull request, #5296:
URL: https://github.com/apache/fineract/pull/5296

   The split-tests.sh script currently only checks if arguments are provided but doesn't validate their values. This can lead to confusing behavior when users pass invalid inputs like negative numbers, zero, or non-numeric values.
   
   This change adds basic input validation to make the script more robust and user-friendly. Now when someone runs the script with invalid arguments (like ./split-tests.sh 0 5 or ./split-tests.sh 3 abc), they'll get a clear error message explaining what went wrong instead of the script failing mysteriously later.
   
   The validation ensures:
   
   Both arguments are positive integers (no zero, negative, or text values)
   
   The shard index doesn't exceed the total number of shards
   
   Users get helpful error messages when something is wrong
   
   This is a small improvement that makes the script safer and easier to use, especially for new contributors who might not be familiar with the expected input format.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add input validation to split-tests.sh script [fineract]

Posted by "IOhacker (via GitHub)" <gi...@apache.org>.
IOhacker commented on PR #5296:
URL: https://github.com/apache/fineract/pull/5296#issuecomment-3719762758

   Please add this Jira Ticket on the commit and the PR "FINERACT-2434" 
   Please help us to open Jira Tickets for any PR https://issues.apache.org/jira/browse/FINERACT-2434


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] FINERACT-2434: Add input validation to split-tests.sh script [fineract]

Posted by "fintecheando (via GitHub)" <gi...@apache.org>.
fintecheando commented on PR #5296:
URL: https://github.com/apache/fineract/pull/5296#issuecomment-3720932801

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] FINERACT-2434: Add input validation to split-tests.sh script [fineract]

Posted by "IOhacker (via GitHub)" <gi...@apache.org>.
IOhacker merged PR #5296:
URL: https://github.com/apache/fineract/pull/5296


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org