You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by sl4mmy <gi...@git.apache.org> on 2018/07/23 20:10:55 UTC
[GitHub] zookeeper pull request #581: ZOOKEEPER-3101: add reminder to ZOO_ERRORS
GitHub user sl4mmy opened a pull request:
https://github.com/apache/zookeeper/pull/581
ZOOKEEPER-3101: add reminder to ZOO_ERRORS
Add comment at bottom of ZOO_ERRORS reminding developers to also
update zerror(int) when adding or changing values. Suggested by
@phunt in https://github.com/apache/zookeeper/pull/575#issuecomment-406356144.
Signed-off-by: Kent R. Spillner <ks...@acm.org>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sl4mmy/zookeeper zookeeper-3101
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/581.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #581
----
commit 757cb545d1f98a0fad46818d96b0abb89b6a47b8
Author: Kent R. Spillner <ks...@...>
Date: 2018-07-23T20:05:35Z
ZOOKEEPER-3101: add reminder to ZOO_ERRORS
Add comment at bottom of ZOO_ERRORS reminding developers to also
update zerror(int) when adding or changing values. Suggested by
@phunt in https://github.com/apache/zookeeper/pull/575#issuecomment-406356144.
Signed-off-by: Kent R. Spillner <ks...@acm.org>
----
---
[GitHub] zookeeper issue #581: ZOOKEEPER-3101: add reminder to ZOO_ERRORS
Posted by sl4mmy <gi...@git.apache.org>.
Github user sl4mmy commented on the issue:
https://github.com/apache/zookeeper/pull/581
The Jenkins failure looks like an internal error in Jenkins itself: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1987/consoleText
---
[GitHub] zookeeper issue #581: ZOOKEEPER-3101: add reminder to ZOO_ERRORS
Posted by lvfangmin <gi...@git.apache.org>.
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/581
+1 looks like the Jenkins failed due to "NoClassDefFoundError: hudson.model.Computer", is it an environment issue?
---
[GitHub] zookeeper issue #581: ZOOKEEPER-3101: add reminder to ZOO_ERRORS
Posted by anmolnar <gi...@git.apache.org>.
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/581
@sl4mmy Would you please trigger another Jenkins build, so that we get a green one and I can commit.
---
[GitHub] zookeeper issue #581: ZOOKEEPER-3101: add reminder to ZOO_ERRORS
Posted by nkalmar <gi...@git.apache.org>.
Github user nkalmar commented on the issue:
https://github.com/apache/zookeeper/pull/581
Yes, all PR fails due to the same reason. I think there is already an INFRA ticket but I'll double check.
---
[GitHub] zookeeper issue #581: ZOOKEEPER-3101: add reminder to ZOO_ERRORS
Posted by sl4mmy <gi...@git.apache.org>.
Github user sl4mmy commented on the issue:
https://github.com/apache/zookeeper/pull/581
@anmolnar Done, and it passed. Thanks!
---
[GitHub] zookeeper issue #581: ZOOKEEPER-3101: add reminder to ZOO_ERRORS
Posted by sl4mmy <gi...@git.apache.org>.
Github user sl4mmy commented on the issue:
https://github.com/apache/zookeeper/pull/581
This commit just adds a comment so I'm not sure how it would cause a build failure other than a style alert, but that doesn't appear to be the case
---
[GitHub] zookeeper issue #581: ZOOKEEPER-3101: add reminder to ZOO_ERRORS
Posted by nkalmar <gi...@git.apache.org>.
Github user nkalmar commented on the issue:
https://github.com/apache/zookeeper/pull/581
Looks to me jenkins was simply overloaded.
You can re-run the jenkins job by doing an empty --amend commit and pushing it to your PR branch.
---
[GitHub] zookeeper issue #581: ZOOKEEPER-3101: add reminder to ZOO_ERRORS
Posted by sl4mmy <gi...@git.apache.org>.
Github user sl4mmy commented on the issue:
https://github.com/apache/zookeeper/pull/581
@nkalmar Thanks, I just pushed a new commit (slightly reworded the commit message) but the Jenkins build failed again for the same reason: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1990/console
---