You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/04/11 10:45:00 UTC
[GitHub] [incubator-nuttx] no1wudi opened a new pull request, #6034: arch/risc-v: Apply common mtime driver to mtime based chps
no1wudi opened a new pull request, #6034:
URL: https://github.com/apache/incubator-nuttx/pull/6034
## Summary
See #6020, apply it to k210/bl602/qemu_rv etc
## Impact
risc-v based chips
## Testing
rv-virt/k210/bl602
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko merged pull request #6034: arch/risc-v: Apply common mtime driver to mtime based chps
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged PR #6034:
URL: https://github.com/apache/incubator-nuttx/pull/6034
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6034: arch/risc-v: Apply common mtime driver to mtime based chps
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #6034:
URL: https://github.com/apache/incubator-nuttx/pull/6034#issuecomment-1095361099
> I still observe some warnings on a CI
>
> ```
> .config:118:warning: symbol value '' invalid for ARCH_CPU_COUNT
> Building NuttX...
> Makefile:123: target 'riscv_cpuindex.o' given more than once in the same rule
> Makefile:123: target 'riscv_cpuindex.o' given more than once in the same rule
> Makefile:123: target 'riscv_cpuindex.o' given more than once in the same rule
> Makefile:123: target 'riscv_cpuindex.o' given more than once in the same rule
> Makefile:123: target 'riscv_cpuindex.o' given more than once in the same rule
> Normalize maix-bit/smp2
> .config:118:warning: symbol value '' invalid for ARCH_CPU_COUNT
> .config:118:warning: symbol value '' invalid for ARCH_CPU_COUNT
> ```
>
> I think that `.config:118:warning: symbol value '' invalid for ARCH_CPU_COUNT` is known and should be addressed soon, but `Makefile:123: target 'riscv_cpuindex.o' given more than once in the same rule` seems to be a new one
Both issues are fixed by https://github.com/apache/incubator-nuttx/pull/5985
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6034: arch/risc-v: Apply common mtime driver to mtime based chps
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #6034:
URL: https://github.com/apache/incubator-nuttx/pull/6034#issuecomment-1094995707
@pussuw could you try this patch with MPFS?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #6034: arch/risc-v: Apply common mtime driver to mtime based chps
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #6034:
URL: https://github.com/apache/incubator-nuttx/pull/6034#issuecomment-1095296094
I still observe some warnings on a CI
```
.config:118:warning: symbol value '' invalid for ARCH_CPU_COUNT
Building NuttX...
Makefile:123: target 'riscv_cpuindex.o' given more than once in the same rule
Makefile:123: target 'riscv_cpuindex.o' given more than once in the same rule
Makefile:123: target 'riscv_cpuindex.o' given more than once in the same rule
Makefile:123: target 'riscv_cpuindex.o' given more than once in the same rule
Makefile:123: target 'riscv_cpuindex.o' given more than once in the same rule
Normalize maix-bit/smp2
.config:118:warning: symbol value '' invalid for ARCH_CPU_COUNT
.config:118:warning: symbol value '' invalid for ARCH_CPU_COUNT
```
I think that `.config:118:warning: symbol value '' invalid for ARCH_CPU_COUNT` is known and should be addressed soon, but `Makefile:123: target 'riscv_cpuindex.o' given more than once in the same rule` seems to be a new one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6034: arch/risc-v: Apply common mtime driver to mtime based chps
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #6034:
URL: https://github.com/apache/incubator-nuttx/pull/6034#discussion_r847538224
##########
arch/risc-v/src/c906/c906_timerisr.c:
##########
@@ -117,15 +64,7 @@ static int c906_timerisr(int irq, void *context, void *arg)
void up_timer_initialize(void)
{
- /* Attach timer interrupt handler */
-
- irq_attach(RISCV_IRQ_MTIMER, c906_timerisr, NULL);
-
- /* Reload CLINT mtimecmp */
-
- c906_reload_mtimecmp();
-
- /* And enable the timer interrupt */
-
- up_enable_irq(RISCV_IRQ_MTIMER);
+ up_alarm_set_lowerhalf(riscv_mtimer_initialize(
Review Comment:
can we use temp variable here, just for easy reading?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pussuw commented on pull request #6034: arch/risc-v: Apply common mtime driver to mtime based chps
Posted by GitBox <gi...@apache.org>.
pussuw commented on PR #6034:
URL: https://github.com/apache/incubator-nuttx/pull/6034#issuecomment-1095032341
> @pussuw could you try this patch with MPFS?
Yes, goes to tomorrow though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #6034: arch/risc-v: Apply common mtime driver to mtime based chps
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #6034:
URL: https://github.com/apache/incubator-nuttx/pull/6034#issuecomment-1095294774
In general LGTM!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] no1wudi commented on a diff in pull request #6034: arch/risc-v: Apply common mtime driver to mtime based chps
Posted by GitBox <gi...@apache.org>.
no1wudi commented on code in PR #6034:
URL: https://github.com/apache/incubator-nuttx/pull/6034#discussion_r848102629
##########
arch/risc-v/src/c906/c906_timerisr.c:
##########
@@ -117,15 +64,7 @@ static int c906_timerisr(int irq, void *context, void *arg)
void up_timer_initialize(void)
{
- /* Attach timer interrupt handler */
-
- irq_attach(RISCV_IRQ_MTIMER, c906_timerisr, NULL);
-
- /* Reload CLINT mtimecmp */
-
- c906_reload_mtimecmp();
-
- /* And enable the timer interrupt */
-
- up_enable_irq(RISCV_IRQ_MTIMER);
+ up_alarm_set_lowerhalf(riscv_mtimer_initialize(
Review Comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org