You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/19 04:08:20 UTC

[GitHub] [arrow-rs] Ted-Jiang commented on a diff in pull request #2105: add test for skip_values in DictionaryDecoder and fix it

Ted-Jiang commented on code in PR #2105:
URL: https://github.com/apache/arrow-rs/pull/2105#discussion_r924039924


##########
parquet/src/arrow/array_reader/byte_array_dictionary.rs:
##########
@@ -346,6 +346,7 @@ where
                         // Keys will be validated on conversion to arrow
                         let keys_slice = keys.spare_capacity_mut(range.start + len);
                         let len = decoder.get_batch(&mut keys_slice[range.start..])?;
+                        *max_remaining_values -= len;

Review Comment:
   miss this will fail at record skip count.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org