You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampark.apache.org by "CuteShaos (via GitHub)" <gi...@apache.org> on 2025/08/29 15:19:39 UTC
[PR] [Bug] The getFinalSavepointDir did not receive the processPath return value, resulting in redundant calls and logical errors [streampark]
CuteShaos opened a new pull request, #4279:
URL: https://github.com/apache/streampark/pull/4279
In the getFinalSavepointDir method, the processPath function is called but its return value is not assigned to any variable. This leads to the processed path being discarded, requiring the caller to call processPath again on the returned result. This causes:
1. Redundant computation (same path processing executed twice)
2. Inconsistent value handling (the method returns unprocessed value but expects it to be processed)
3. Logical fragility (if processPath has side effects, they would occur twice)
<!--
Thank you for contributing to StreamPark! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
## Contribution Checklist
- If this is your first time, please read our contributor guidelines: [Submit Code](https://streampark.apache.org/community/submit_guide/submit_code).
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/streampark/issues).
- Name the pull request in the form "[Feature] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- If the PR is unfinished, add `[WIP]` in your PR title, e.g., `[WIP][Feature] Title of the pull request`.
-->
## What changes were proposed in this pull request
Issue Number: close #4278 <!-- REMOVE this line if no issue to close -->
<!--(For example: This pull request proposed to add checkstyle plugin).-->
## Brief change log
- *Use the result variable to receive the return value of the processPath method: result = processPath(result, application.getJobName(), application.getId());*
- *Delete redundant calculations*
## Verifying this change
- This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts
- Dependencies (does it add or upgrade a dependency): no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Bug] The getFinalSavepointDir did not receive the processPath return value, resulting in redundant calls and logical errors [streampark]
Posted by "CuteShaos (via GitHub)" <gi...@apache.org>.
CuteShaos closed pull request #4279: [Bug] The getFinalSavepointDir did not receive the processPath return value, resulting in redundant calls and logical errors
URL: https://github.com/apache/streampark/pull/4279
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Bug] The getFinalSavepointDir did not receive the processPath return value, resulting in redundant calls and logical errors [streampark]
Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys commented on PR #4279:
URL: https://github.com/apache/streampark/pull/4279#issuecomment-3237477473
Great, the 2.1.6 version has been released. Could you submit this PR to the dev branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Bug] The getFinalSavepointDir did not receive the processPath return value, resulting in redundant calls and logical errors [streampark]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #4279:
URL: https://github.com/apache/streampark/pull/4279#issuecomment-3237405485
## [](https://sonarcloud.io/dashboard?id=apache_incubator-streampark&pullRequest=4279) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_incubator-streampark&pullRequest=4279&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_incubator-streampark&pullRequest=4279&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-streampark&pullRequest=4279&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_incubator-streampark&pullRequest=4279&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_incubator-streampark&pullRequest=4279&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_incubator-streampark&pullRequest=4279)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Bug] The getFinalSavepointDir did not receive the processPath return value, resulting in redundant calls and logical errors [streampark]
Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys commented on PR #4279:
URL: https://github.com/apache/streampark/pull/4279#issuecomment-3239734209
You can submit a new PR to enable variable support for the savepoint path in the dev branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Bug] The getFinalSavepointDir did not receive the processPath return value, resulting in redundant calls and logical errors [streampark]
Posted by "CuteShaos (via GitHub)" <gi...@apache.org>.
CuteShaos commented on PR #4279:
URL: https://github.com/apache/streampark/pull/4279#issuecomment-3238944829
The processPath method is no longer available in the getFinalSavepointDir method of the dev branch, so it should no longer support variables, so there won't be any problems. Do we need to close this pr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org