You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yingchun Lai (Code Review)" <ge...@cloudera.org> on 2023/10/25 04:51:52 UTC
[kudu-CR](branch-1.17.x) [thirdparty] Fix the curl missing patch
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/20621
to review the following change.
Change subject: [thirdparty] Fix the curl missing patch
......................................................................
[thirdparty] Fix the curl missing patch
This is a follow-up patch for commit:
28c9218172d366832b1f9881cfbc7f159afd3029, the previous
commit missed to patch both of the two patches of curl.
Change-Id: Ib997c7c304e9d55e1fe16d28f1dca53500d69ba7
Reviewed-on: http://gerrit.cloudera.org:8080/20620
Reviewed-by: Alexey Serbin <al...@apache.org>
Tested-by: Kudu Jenkins
(cherry picked from commit 0dbd63ad942835593b6fb028ad4fdfaaee289526)
---
M thirdparty/download-thirdparty.sh
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/20621/1
--
To view, visit http://gerrit.cloudera.org:8080/20621
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib997c7c304e9d55e1fe16d28f1dca53500d69ba7
Gerrit-Change-Number: 20621
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.17.x) [thirdparty] Fix the curl missing patch
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20621 )
Change subject: [thirdparty] Fix the curl missing patch
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20621
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib997c7c304e9d55e1fe16d28f1dca53500d69ba7
Gerrit-Change-Number: 20621
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 25 Oct 2023 05:40:45 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) [thirdparty] Fix the curl missing patch
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20621 )
Change subject: [thirdparty] Fix the curl missing patch
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/20621
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib997c7c304e9d55e1fe16d28f1dca53500d69ba7
Gerrit-Change-Number: 20621
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Wed, 25 Oct 2023 06:08:45 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) [thirdparty] Fix the curl missing patch
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20621 )
Change subject: [thirdparty] Fix the curl missing patch
......................................................................
[thirdparty] Fix the curl missing patch
This is a follow-up patch for commit:
28c9218172d366832b1f9881cfbc7f159afd3029, the previous
commit missed to patch both of the two patches of curl.
Change-Id: Ib997c7c304e9d55e1fe16d28f1dca53500d69ba7
Reviewed-on: http://gerrit.cloudera.org:8080/20620
Reviewed-by: Alexey Serbin <al...@apache.org>
Tested-by: Kudu Jenkins
(cherry picked from commit 0dbd63ad942835593b6fb028ad4fdfaaee289526)
Reviewed-on: http://gerrit.cloudera.org:8080/20621
Tested-by: Yingchun Lai <la...@apache.org>
---
M thirdparty/download-thirdparty.sh
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Yingchun Lai: Verified
--
To view, visit http://gerrit.cloudera.org:8080/20621
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib997c7c304e9d55e1fe16d28f1dca53500d69ba7
Gerrit-Change-Number: 20621
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR](branch-1.17.x) [thirdparty] Fix the curl missing patch
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has removed a vote on this change.
Change subject: [thirdparty] Fix the curl missing patch
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/20621
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ib997c7c304e9d55e1fe16d28f1dca53500d69ba7
Gerrit-Change-Number: 20621
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>