You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2014/01/27 23:16:13 UTC
Review Request 17427: Handled EINTR in os::close.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17427/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Ian Downes, and Vinod Kone.
Repository: mesos-git
Description
-------
See above, note that GNU offers TEMP_FAILURE_RETRY as a macro for this.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp bba6f43eaeba0238a5db6e388902d92eb18f14f5
Diff: https://reviews.apache.org/r/17427/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request 17427: Handled EINTR in os::close.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17427/#review32908
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On Jan. 27, 2014, 10:16 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17427/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2014, 10:16 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ian Downes, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See above, note that GNU offers TEMP_FAILURE_RETRY as a macro for this.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp bba6f43eaeba0238a5db6e388902d92eb18f14f5
>
> Diff: https://reviews.apache.org/r/17427/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 17427: Handled EINTR in os::close.
Posted by Ian Downes <ia...@gmail.com>.
> On Jan. 27, 2014, 11:54 p.m., Ian Downes wrote:
> > According to Linus the file descriptor has been closed even if EINTR is returned and it should not be closed again. Later in the thread he explicitly says that the glibc macro is incorrect.
> >
> > http://linux.derkeiler.com/Mailing-Lists/Kernel/2005-09/3000.html
> >
> > Posix documentation says the state of the file descriptor is unspecified on EINTR.
[Incorrect in the sense that it shouldn't be used to wrap a close()]
- Ian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17427/#review32914
-----------------------------------------------------------
On Jan. 27, 2014, 10:16 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17427/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2014, 10:16 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ian Downes, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See above, note that GNU offers TEMP_FAILURE_RETRY as a macro for this.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp bba6f43eaeba0238a5db6e388902d92eb18f14f5
>
> Diff: https://reviews.apache.org/r/17427/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 17427: Handled EINTR in os::close.
Posted by Ben Mahler <be...@gmail.com>.
> On Jan. 27, 2014, 11:54 p.m., Ian Downes wrote:
> > According to Linus the file descriptor has been closed even if EINTR is returned and it should not be closed again. Later in the thread he explicitly says that the glibc macro is incorrect.
> >
> > http://linux.derkeiler.com/Mailing-Lists/Kernel/2005-09/3000.html
> >
> > Posix documentation says the state of the file descriptor is unspecified on EINTR.
>
> Ian Downes wrote:
> [Incorrect in the sense that it shouldn't be used to wrap a close()]
Yikes, thank you for finding this Ian!
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17427/#review32914
-----------------------------------------------------------
On Jan. 27, 2014, 10:16 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17427/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2014, 10:16 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ian Downes, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See above, note that GNU offers TEMP_FAILURE_RETRY as a macro for this.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp bba6f43eaeba0238a5db6e388902d92eb18f14f5
>
> Diff: https://reviews.apache.org/r/17427/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 17427: Handled EINTR in os::close.
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17427/#review32914
-----------------------------------------------------------
According to Linus the file descriptor has been closed even if EINTR is returned and it should not be closed again. Later in the thread he explicitly says that the glibc macro is incorrect.
http://linux.derkeiler.com/Mailing-Lists/Kernel/2005-09/3000.html
Posix documentation says the state of the file descriptor is unspecified on EINTR.
- Ian Downes
On Jan. 27, 2014, 10:16 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17427/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2014, 10:16 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ian Downes, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See above, note that GNU offers TEMP_FAILURE_RETRY as a macro for this.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp bba6f43eaeba0238a5db6e388902d92eb18f14f5
>
> Diff: https://reviews.apache.org/r/17427/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>