You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Hudson (Jira)" <ji...@apache.org> on 2020/06/22 13:47:00 UTC
[jira] [Commented] (HBASE-24591) get_table_rsgroup ignored the
existence of rsgroup config for namespace
[ https://issues.apache.org/jira/browse/HBASE-24591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142052#comment-17142052 ]
Hudson commented on HBASE-24591:
--------------------------------
Results for branch master
[build #1764 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1764/]: (x) *{color:red}-1 overall{color}*
----
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/master/1764/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/master/1663//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/master/1764/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 report|https://builds.apache.org/job/HBase%20Nightly/job/master/1764/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> get_table_rsgroup ignored the existence of rsgroup config for namespace
> -----------------------------------------------------------------------
>
> Key: HBASE-24591
> URL: https://issues.apache.org/jira/browse/HBASE-24591
> Project: HBase
> Issue Type: Bug
> Components: rsgroup
> Affects Versions: 3.0.0-alpha-1
> Reporter: Sun Xin
> Assignee: Sun Xin
> Priority: Major
> Fix For: 3.0.0-alpha-1
>
>
> {code:java}
> public GetRSGroupInfoOfTableResponse getRSGroupInfoOfTable(RpcController controller,
> GetRSGroupInfoOfTableRequest request) throws ServiceException {
> TableName tableName = ProtobufUtil.toTableName(request.getTableName());
> ...
> try {
> ...
> GetRSGroupInfoOfTableResponse resp;
> TableDescriptor td = master.getTableDescriptors().get(tableName);
> if (td == null) {
> resp = GetRSGroupInfoOfTableResponse.getDefaultInstance();
> } else {
> RSGroupInfo rsGroupInfo = null;
> if (td.getRegionServerGroup().isPresent()) {
> rsGroupInfo = master.getRSGroupInfoManager().getRSGroup(td.getRegionServerGroup().get());
> }
> if (rsGroupInfo == null) {
> rsGroupInfo = master.getRSGroupInfoManager().getRSGroup(RSGroupInfo.DEFAULT_GROUP);
> }
> resp = GetRSGroupInfoOfTableResponse.newBuilder()
> .setRSGroupInfo(ProtobufUtil.toProtoGroupInfo(rsGroupInfo)).build();
> }
> ...
> return resp;
> } catch (IOException e) {
> throw new ServiceException(e);
> }
> }
> {code}
> In method MasterRpcServices#getRSGroupInfoOfTable, ignored namespace hbase.rsgroup.name config.
>
> It should be replaced by RSGroupUtil#getRSGroupInfo.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)