You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "Arawoof06 (via GitHub)" <gi...@apache.org> on 2026/07/17 07:19:11 UTC
[PR] GH-1232: don't drop TLS for endpoint locations in getStreams [arrow-java]
Arawoof06 opened a new pull request, #1233:
URL: https://github.com/apache/arrow-java/pull/1233
## What's Changed
getStreams clones the connection builder for each advertised endpoint location, and that clone still carries username/password, token and the OAuth config, so whatever it connects to gets the credentials. Encryption for the clone came from the location scheme alone, meaning a `grpc+tcp://` location advertised by the server turned TLS off even for a connection opened with `useEncryption=true`, and the handshake then went out in cleartext to the advertised host. Since the scheme is server-supplied and useEncryption is the user's stated intent, the scheme should not be able to override it downwards; a non-TLS location is now refused through the per-location exception path that is already there for unreachable locations, so the remaining locations are still tried.
Closes #1232.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-1232: don't drop TLS for endpoint locations in getStreams [arrow-java]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #1233:
URL: https://github.com/apache/arrow-java/pull/1233#issuecomment-5403521132
@Arawoof06 please rebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-1232: don't drop TLS for endpoint locations in getStreams [arrow-java]
Posted by "Arawoof06 (via GitHub)" <gi...@apache.org>.
Arawoof06 commented on PR #1233:
URL: https://github.com/apache/arrow-java/pull/1233#issuecomment-6005316010
Rebased onto current main. The August CI runs expired waiting for workflow approval and never started, so the new ones need a maintainer to kick them off. Also joined one wrapped line in the test that the updated google-java-format wanted on a single line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-1232: don't drop TLS for endpoint locations in getStreams [arrow-java]
Posted by "Arawoof06 (via GitHub)" <gi...@apache.org>.
Arawoof06 commented on PR #1233:
URL: https://github.com/apache/arrow-java/pull/1233#issuecomment-5343333236
gentle ping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-1232: don't drop TLS for endpoint locations in getStreams [arrow-java]
Posted by "Arawoof06 (via GitHub)" <gi...@apache.org>.
Arawoof06 commented on PR #1233:
URL: https://github.com/apache/arrow-java/pull/1233#issuecomment-5409518997
Rebased onto main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-1232: don't drop TLS for endpoint locations in getStreams [arrow-java]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1233:
URL: https://github.com/apache/arrow-java/pull/1233#issuecomment-5000124867
<!-- label_helper_comment -->
Thank you for opening a pull request!
Please label the PR with one or more of:
- bug-fix
- chore
- dependencies
- documentation
- enhancement
Also, add the 'breaking-change' label if appropriate.
See [CONTRIBUTING.md](https://github.com/apache/arrow-java/blob/main/CONTRIBUTING.md) for details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org