You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (Created) (JIRA)" <ji...@apache.org> on 2011/11/02 15:49:32 UTC

[jira] [Created] (CASSANDRA-3445) recognize that "SELECT first ... *" isn't really "SELECT *"

recognize that "SELECT first ... *" isn't really "SELECT *"
-----------------------------------------------------------

                 Key: CASSANDRA-3445
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3445
             Project: Cassandra
          Issue Type: Bug
          Components: API
            Reporter: Jonathan Ellis
            Assignee: Jonathan Ellis
            Priority: Minor
             Fix For: 1.1


QueryProcessor includes the row key in "first *" because it mistakenly thinks the full row is being requested.  "first *" should really be treated like a slice.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CASSANDRA-3445) recognize that "SELECT first ... *" isn't really "SELECT *"

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-3445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143464#comment-13143464 ] 

Hudson commented on CASSANDRA-3445:
-----------------------------------

Integrated in Cassandra #1185 (See [https://builds.apache.org/job/Cassandra/1185/])
    recognize that "SELECT first ... *" isn't really "SELECT *"
patch by Pavel Yaskevich; reviewed by Jonathan Ellis for CASSANDRA-3445

xedin : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1197270
Files : 
* /cassandra/trunk/CHANGES.txt
* /cassandra/trunk/src/java/org/apache/cassandra/cql/Cql.g
* /cassandra/trunk/src/java/org/apache/cassandra/cql/QueryProcessor.java
* /cassandra/trunk/src/java/org/apache/cassandra/cql/SelectExpression.java
* /cassandra/trunk/src/java/org/apache/cassandra/cql/SelectStatement.java

                
> recognize that "SELECT first ... *" isn't really "SELECT *"
> -----------------------------------------------------------
>
>                 Key: CASSANDRA-3445
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3445
>             Project: Cassandra
>          Issue Type: Bug
>          Components: API
>            Reporter: Jonathan Ellis
>            Assignee: Pavel Yaskevich
>            Priority: Minor
>              Labels: cql
>             Fix For: 1.1
>
>         Attachments: 3445-skeleton.txt, CASSANDRA-3445.patch
>
>
> QueryProcessor includes the row key in "first *" because it mistakenly thinks the full row is being requested.  "first *" should really be treated like a slice.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CASSANDRA-3445) recognize that "SELECT first ... *" isn't really "SELECT *"

Posted by "Pavel Yaskevich (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-3445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pavel Yaskevich updated CASSANDRA-3445:
---------------------------------------

    Attachment: CASSANDRA-3445.patch

Used Jonathan's skeleton with one modification - SelectStatement.isFullWildcard () was changed to use !hasFirstSet because I think that intention here is not to include the key when "FIRST" keyword is set.
                
> recognize that "SELECT first ... *" isn't really "SELECT *"
> -----------------------------------------------------------
>
>                 Key: CASSANDRA-3445
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3445
>             Project: Cassandra
>          Issue Type: Bug
>          Components: API
>            Reporter: Jonathan Ellis
>            Assignee: Pavel Yaskevich
>            Priority: Minor
>              Labels: cql
>             Fix For: 1.1
>
>         Attachments: 3445-skeleton.txt, CASSANDRA-3445.patch
>
>
> QueryProcessor includes the row key in "first *" because it mistakenly thinks the full row is being requested.  "first *" should really be treated like a slice.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CASSANDRA-3445) recognize that "SELECT first ... *" isn't really "SELECT *"

Posted by "Jonathan Ellis (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-3445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-3445:
--------------------------------------

    Attachment: 3445-skeleton.txt

Would like to take the approach outlined here but there isn't actually a way to tell if the FIRST count was specified in the statement or not w/ the current antlr.  Re-assigning to Pavel for antlr help.
                
> recognize that "SELECT first ... *" isn't really "SELECT *"
> -----------------------------------------------------------
>
>                 Key: CASSANDRA-3445
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3445
>             Project: Cassandra
>          Issue Type: Bug
>          Components: API
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>              Labels: cql
>             Fix For: 1.1
>
>         Attachments: 3445-skeleton.txt
>
>
> QueryProcessor includes the row key in "first *" because it mistakenly thinks the full row is being requested.  "first *" should really be treated like a slice.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CASSANDRA-3445) recognize that "SELECT first ... *" isn't really "SELECT *"

Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-3445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143327#comment-13143327 ] 

Jonathan Ellis commented on CASSANDRA-3445:
-------------------------------------------

+1
                
> recognize that "SELECT first ... *" isn't really "SELECT *"
> -----------------------------------------------------------
>
>                 Key: CASSANDRA-3445
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3445
>             Project: Cassandra
>          Issue Type: Bug
>          Components: API
>            Reporter: Jonathan Ellis
>            Assignee: Pavel Yaskevich
>            Priority: Minor
>              Labels: cql
>             Fix For: 1.1
>
>         Attachments: 3445-skeleton.txt, CASSANDRA-3445.patch
>
>
> QueryProcessor includes the row key in "first *" because it mistakenly thinks the full row is being requested.  "first *" should really be treated like a slice.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CASSANDRA-3445) recognize that "SELECT first ... *" isn't really "SELECT *"

Posted by "Jonathan Ellis (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-3445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-3445:
--------------------------------------

    Reviewer: jbellis
    Assignee: Pavel Yaskevich  (was: Jonathan Ellis)
    
> recognize that "SELECT first ... *" isn't really "SELECT *"
> -----------------------------------------------------------
>
>                 Key: CASSANDRA-3445
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3445
>             Project: Cassandra
>          Issue Type: Bug
>          Components: API
>            Reporter: Jonathan Ellis
>            Assignee: Pavel Yaskevich
>            Priority: Minor
>              Labels: cql
>             Fix For: 1.1
>
>         Attachments: 3445-skeleton.txt
>
>
> QueryProcessor includes the row key in "first *" because it mistakenly thinks the full row is being requested.  "first *" should really be treated like a slice.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira