You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/10/26 08:38:44 UTC
[GitHub] [incubator-kyuubi] cfmcgrady opened a new pull request, #3710: [WIP] Reduce sources file size
cfmcgrady opened a new pull request, #3710:
URL: https://github.com/apache/incubator-kyuubi/pull/3710
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #3710: [WIP] Reduce sources file size
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #3710:
URL: https://github.com/apache/incubator-kyuubi/pull/3710#issuecomment-1291722733
cc @yaooqinn, which way are you preferred?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 closed pull request #3710: Delete the swagger UI related resource files from the source folder
Posted by GitBox <gi...@apache.org>.
pan3793 closed pull request #3710: Delete the swagger UI related resource files from the source folder
URL: https://github.com/apache/incubator-kyuubi/pull/3710
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #3710: [WIP] Reduce sources file size
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #3710:
URL: https://github.com/apache/incubator-kyuubi/pull/3710#issuecomment-1291711967
The alternative is to delete the `*.map` and `*es-bundle*` files.
```
(kyuubi) ➜ swagger git:(master) ✗ ll
total 4096
-rw-r--r-- 1 chengpan staff 665B Jul 14 17:31 favicon-16x16.png
-rw-r--r-- 1 chengpan staff 628B Jul 14 17:31 favicon-32x32.png
-rw-r--r-- 1 chengpan staff 3.3K Jul 14 17:31 index.html
-rw-r--r-- 1 chengpan staff 3.3K Sep 7 20:14 oauth2-redirect.html
-rw-r--r-- 1 chengpan staff 1.0M Jul 14 17:31 swagger-ui-bundle.js
-rw-r--r-- 1 chengpan staff 317K Jul 14 17:31 swagger-ui-standalone-preset.js
-rw-r--r-- 1 chengpan staff 140K Jul 14 17:31 swagger-ui.css
-rw-r--r-- 1 chengpan staff 502K Jul 14 17:31 swagger-ui.js
(kyuubi) ➜ swagger git:(master) ✗ du -hd1
2.0M .
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #3710: Delete the swagger UI related resource files from the source folder
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on PR #3710:
URL: https://github.com/apache/incubator-kyuubi/pull/3710#issuecomment-1294665992
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #3710: Delete the swagger UI related resource files from the source folder
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #3710:
URL: https://github.com/apache/incubator-kyuubi/pull/3710#issuecomment-1295799104
Thanks, merging to master/1.6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] cfmcgrady closed pull request #3710: [WIP] Reduce sources file size
Posted by GitBox <gi...@apache.org>.
cfmcgrady closed pull request #3710: [WIP] Reduce sources file size
URL: https://github.com/apache/incubator-kyuubi/pull/3710
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org