You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "EdColeman (via GitHub)" <gi...@apache.org> on 2023/07/25 22:33:10 UTC
[GitHub] [accumulo] EdColeman opened a new pull request, #3659: make option exclude-parent-properties, other minor clean-up
EdColeman opened a new pull request, #3659:
URL: https://github.com/apache/accumulo/pull/3659
- Change command option from `exclude-parent` to `exclude-parent-properties` for clarity.
- clarify command description present to uses
- comment clean-up
From additional comment in PR #3562 made after merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] EdColeman merged pull request #3659: make option exclude-parent-properties, other minor clean-up
Posted by "EdColeman (via GitHub)" <gi...@apache.org>.
EdColeman merged PR #3659:
URL: https://github.com/apache/accumulo/pull/3659
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] EdColeman commented on pull request #3659: make option exclude-parent-properties, other minor clean-up
Posted by "EdColeman (via GitHub)" <gi...@apache.org>.
EdColeman commented on PR #3659:
URL: https://github.com/apache/accumulo/pull/3659#issuecomment-1654606715
I manually triggered a re-run just to double check (https://github.com/apache/accumulo/actions/runs/5662956604)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on pull request #3659: make option exclude-parent-properties, other minor clean-up
Posted by "ctubbsii (via GitHub)" <gi...@apache.org>.
ctubbsii commented on PR #3659:
URL: https://github.com/apache/accumulo/pull/3659#issuecomment-1654384648
This PR doesn't seem to be triggering the GitHub Actions CI checks for some reason. Not really sure what's going on there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on a diff in pull request #3659: make option exclude-parent-properties, other minor clean-up
Posted by "ctubbsii (via GitHub)" <gi...@apache.org>.
ctubbsii commented on code in PR #3659:
URL: https://github.com/apache/accumulo/pull/3659#discussion_r1276726880
##########
shell/src/main/java/org/apache/accumulo/shell/commands/CreateNamespaceCommand.java:
##########
@@ -44,7 +44,7 @@ public int execute(final String fullCommand, final CommandLine cl, final Shell s
TableNotFoundException, IOException, ClassNotFoundException, NamespaceExistsException,
NamespaceNotFoundException {
- // validate that copy config and copy properties options are mutually exclusive.
+ // exclude parent properties only valid with copy config
Review Comment:
```suggestion
// exclude parent properties; only valid with copy config
```
##########
shell/src/main/java/org/apache/accumulo/shell/commands/CreateTableCommand.java:
##########
@@ -101,7 +101,7 @@ public int execute(final String fullCommand, final CommandLine cl, final Shell s
new TreeSet<>(shellState.getAccumuloClient().tableOperations().listSplits(oldTable)));
}
- // allow only copy config or copy properties,
+ // exclude parent properties only valid with copy config
Review Comment:
```suggestion
// exclude parent properties; only valid with copy config
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org