Re: [GitHub] incubator-tinkerpop pull request:

[Matt Frantz <ma...@gmail.com>]

It seems that the set of Java packages that a client needs to know about
should be circumscribed.  The packages containing the step classes are not
part of that set, are they?

On Fri, Oct 9, 2015 at 3:17 PM, Marko Rodriguez <ok...@gmail.com>
wrote:

> Hi,
>
> We could pull it out to the level of T. Why does it matter? I would only
> pull it out if we would reuse the Column enum in other situations… ?
>
> Marko.
>
> http://markorodriguez.com
>
> On Oct 9, 2015, at 4:08 PM, mhfrantz <gi...@git.apache.org> wrote:
>
> > Github user mhfrantz commented on the pull request:
> >
> >
> https://github.com/apache/incubator-tinkerpop/commit/16d6078ca810e70cb3f62d98fcbbc244819f5bae#commitcomment-13696462
> >
> >    In
> gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.java:
> >    In
> gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.java
> on line 468:
> >    Seems awkward to have the column enum inside of a step class
> interface.  Is there a precedent for this idiom?
> >
> >
> > ---
> > If your project is set up for it, you can reply to this email and have
> your
> > reply appear on GitHub as well. If your project does not have this
> feature
> > enabled and wishes so, or if the feature is enabled but not working,
> please
> > contact infrastructure at infrastructure@apache.org or file a JIRA
> ticket
> > with INFRA.
> > ---
>
>