[GitHub] spark pull request: SPARK-1144 Added license and RAT to check lice...

[tdas <gi...@git.apache.org>]

Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/125#discussion_r10769839
  
    --- Diff: dev/run-tests ---
    @@ -36,6 +36,21 @@ fi
     JAVA_VERSION=$($java_cmd -version 2>&1 | sed 's/java version "\(.*\)\.\(.*\)\..*"/\1\2/; 1q')
     [ "$JAVA_VERSION" -ge 18 ] && echo "" || echo "[Warn] Java 8 tests will not run, because JDK version is < 1.8."
     
    +export RAT_VERSION=0.10
    +export rat_jar=$FWDIR/lib/apache-rat-${RAT_VERSION}.jar
    +mkdir -p $FWDIR/lib
    +
    +source $FWDIR/dev/rat.bash
    +
    +echo "========================================================================="
    +echo "Running Apache RAT checks"
    +echo "========================================================================="
    +[[ -f "$rat_jar" ]] || acquire_rat_jar || {
    +    echo "Download failed. Obtain the rat jar manually and place it at $rat_jar"
    +    exit 1
    +}
    +
    +$java_cmd -jar $rat_jar -E $FWDIR/.rat-excludes  -d $FWDIR
    --- End diff --
    
    Its better to move all this RAT functionality to a different script in dev (say, check-license, which will subsume acquire_rat_jar) and run_test will simply call that script. This keeps this run_test script simple. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---