[GitHub] [spark] 07ARB commented on a change in pull request #26773: [SPARK-30126][CORE]sparkContext.addFile fails when file path contains…

[GitBox <gi...@apache.org>]

07ARB commented on a change in pull request #26773: [SPARK-30126][CORE]sparkContext.addFile fails when file path contains…
URL: https://github.com/apache/spark/pull/26773#discussion_r354722031
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/SparkContext.scala
 ##########
 @@ -1538,7 +1538,7 @@ class SparkContext(config: SparkConf) extends Logging {
     val scheme = new URI(schemeCorrectedPath).getScheme
     if (!Array("http", "https", "ftp").contains(scheme)) {
       val fs = hadoopPath.getFileSystem(hadoopConfiguration)
-      val isDir = fs.getFileStatus(hadoopPath).isDirectory
+      val isDir = fs.getFileStatus(new Path(path)).isDirectory
 
 Review comment:
   @cloud-fan,  yes ,
   org.apache.hadoop.fs.RawLocalFileSystem#deprecatedGetFileStatus (inside this method path.exists will return false)
   because java.io.File#exists method will return false (resion:- the file denoted by this abstract pathname is not exists)
   becuase space is got encoded by %20 but if will pass simple path then it will find the file and will return true.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org