You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/11/10 23:00:34 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #6530: [AIRFLOW-5878] Use JobID to monitor statuses when running a Dataflow …

mik-laj commented on a change in pull request #6530: [AIRFLOW-5878] Use JobID to monitor statuses when running a Dataflow …
URL: https://github.com/apache/airflow/pull/6530#discussion_r344520883
 
 

 ##########
 File path: tests/gcp/hooks/test_dataflow.py
 ##########
 @@ -315,9 +315,10 @@ def test_start_template_dataflow(self, internal_dataflow_mock):
             DATAFLOW_OPTIONS_JAVA['project']
         )
 
+    @mock.patch(DATAFLOW_STRING.format('uuid.uuid4'), return_value=MOCK_UUID)
     @mock.patch(DATAFLOW_STRING.format('_DataflowJobsController'))
     @mock.patch(DATAFLOW_STRING.format('DataFlowHook.get_conn'))
-    def test_start_template_dataflow_with_runtime_env(self, mock_conn, mock_dataflowjob):
+    def test_start_template_dataflow_with_runtime_env(self, mock_conn, mock_dataflowjob, mocck_uuid):
 
 Review comment:
   Updated. Thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services