You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/11/14 07:11:52 UTC
[GitHub] [doris] BiteTheDDDDt opened a new pull request, #14249: [Chore](env) add error information when DORIS_GCC_HOME not set well
BiteTheDDDDt opened a new pull request, #14249:
URL: https://github.com/apache/doris/pull/14249
# Proposed changes
add error information when DORIS_GCC_HOME not set well
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14249: [Chore](env) add error information when DORIS_GCC_HOME not set well
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14249:
URL: https://github.com/apache/doris/pull/14249#issuecomment-1313195801
#### `sh-checker report`
To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/3459281027") output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In env.sh line 165:
export DORIS_GCC_HOME="$(dirname "$(which gcc)")/.."
^------------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
In env.sh line 168:
if [ ! -f "${DORIS_GCC_HOME}/bin/gcc" ];then
^-- SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
Did you mean:
if [[ ! -f "${DORIS_GCC_HOME}/bin/gcc" ]];then
For more information:
https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ...
https://www.shellcheck.net/wiki/SC2292 -- Prefer [[ ]] over [ ] for tests i...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- env.sh.orig
+++ env.sh
@@ -165,7 +165,7 @@
export DORIS_GCC_HOME="$(dirname "$(which gcc)")/.."
fi
-if [ ! -f "${DORIS_GCC_HOME}/bin/gcc" ];then
+if [ ! -f "${DORIS_GCC_HOME}/bin/gcc" ]; then
echo "Error: wrong directory DORIS_GCC_HOME=${DORIS_GCC_HOME}"
exit 1
fi
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14249: [Chore](env) add error information when DORIS_GCC_HOME not set well
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14249:
URL: https://github.com/apache/doris/pull/14249#issuecomment-1313202718
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14249: [Chore](env) add error information when DORIS_GCC_HOME not set well
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14249:
URL: https://github.com/apache/doris/pull/14249#issuecomment-1313202751
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #14249: [Chore](env) add error information when DORIS_GCC_HOME not set well
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #14249:
URL: https://github.com/apache/doris/pull/14249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14249: [Chore](env) add error information when DORIS_GCC_HOME not set well
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14249:
URL: https://github.com/apache/doris/pull/14249#issuecomment-1313199010
#### `sh-checker report`
To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/3459297631") output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' found no issues.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- env.sh.orig
+++ env.sh
@@ -166,7 +166,7 @@
export DORIS_GCC_HOME
fi
-if [[ ! -f "${DORIS_GCC_HOME}/bin/gcc" ]];then
+if [[ ! -f "${DORIS_GCC_HOME}/bin/gcc" ]]; then
echo "Error: wrong directory DORIS_GCC_HOME=${DORIS_GCC_HOME}"
exit 1
fi
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #14249: [Chore](env) add error information when DORIS_GCC_HOME not set well
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #14249:
URL: https://github.com/apache/doris/pull/14249#issuecomment-1313246895
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.34 seconds
load time: 423 seconds
storage size: 17153912961 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221114080625_clickbench_pr_45535.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org