You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by "njriasan (via GitHub)" <gi...@apache.org> on 2023/08/03 04:55:00 UTC

[GitHub] [calcite] njriasan commented on pull request #3329: [CALCITE-5864] Convert interval weeks and quarters into the correct millisecond total

njriasan commented on PR #3329:
URL: https://github.com/apache/calcite/pull/3329#issuecomment-1663288681

   @jsternberg Wanted to comment an issue with this approach I found in case you still care about this. Inside `RexLiteral` the `intervalString` method uses the typeName information directly instead of the actual qualifier in `getTimeUnits()`. As a result, if you try convert from Rex to SQL, you will accidentally multiply the underlying value (by 7 for week and 3 for quarter). 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org