You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by ji...@apache.org on 2016/01/26 01:52:32 UTC

[1/3] mesos git commit: Improved code style slightly in stout.

Repository: mesos
Updated Branches:
  refs/heads/master f8ab6d091 -> 1f396b9a1


Improved code style slightly in stout.

Review: https://reviews.apache.org/r/42764/


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/0f493b55
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/0f493b55
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/0f493b55

Branch: refs/heads/master
Commit: 0f493b55689b9c4fe77b2f7ccebd6d1a73a49b7d
Parents: f8ab6d0
Author: Neil Conway <ne...@gmail.com>
Authored: Mon Jan 25 16:52:03 2016 -0800
Committer: Jie Yu <yu...@gmail.com>
Committed: Mon Jan 25 16:52:03 2016 -0800

----------------------------------------------------------------------
 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp | 3 +--
 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp        | 4 +---
 2 files changed, 2 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/0f493b55/3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp
----------------------------------------------------------------------
diff --git a/3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp b/3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp
index f302d2a..c20e2ff 100644
--- a/3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp
+++ b/3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp
@@ -173,10 +173,9 @@ inline std::vector<std::string> split(
 {
   std::vector<std::string> tokens;
   size_t offset = 0;
-  size_t next = 0;
 
   while (n.isNone() || n.get() > 0) {
-    next = s.find_first_of(delims, offset);
+    size_t next = s.find_first_of(delims, offset);
     if (next == std::string::npos) {
       tokens.push_back(s.substr(offset));
       break;

http://git-wip-us.apache.org/repos/asf/mesos/blob/0f493b55/3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp
----------------------------------------------------------------------
diff --git a/3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp b/3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp
index dc8cf74..4b7d134 100644
--- a/3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp
+++ b/3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp
@@ -195,9 +195,7 @@ TEST_F(OsTest, Nonblock)
   int pipes[2];
   ASSERT_NE(-1, pipe(pipes));
 
-  Try<bool> isNonBlock = false;
-
-  isNonBlock = os::isNonblock(pipes[0]);
+  Try<bool> isNonBlock = os::isNonblock(pipes[0]);
   EXPECT_SOME_FALSE(isNonBlock);
 
   ASSERT_SOME(os::nonblock(pipes[0]));


[3/3] mesos git commit: Removed an unused variable in jvm.cpp.

Posted by ji...@apache.org.
Removed an unused variable in jvm.cpp.

Review: https://reviews.apache.org/r/42766/


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/1f396b9a
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/1f396b9a
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/1f396b9a

Branch: refs/heads/master
Commit: 1f396b9a17bec80fc6fa4f3a47322898faee3a98
Parents: 1aeed33
Author: Neil Conway <ne...@gmail.com>
Authored: Mon Jan 25 16:52:14 2016 -0800
Committer: Jie Yu <yu...@gmail.com>
Committed: Mon Jan 25 16:52:14 2016 -0800

----------------------------------------------------------------------
 src/jvm/jvm.cpp | 1 -
 1 file changed, 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/1f396b9a/src/jvm/jvm.cpp
----------------------------------------------------------------------
diff --git a/src/jvm/jvm.cpp b/src/jvm/jvm.cpp
index d831c9d..909d34a 100644
--- a/src/jvm/jvm.cpp
+++ b/src/jvm/jvm.cpp
@@ -580,7 +580,6 @@ jmethodID Jvm::findMethod(
 
   std::ostringstream signature;
   signature << "(";
-  std::vector<Jvm::Class>::iterator args;
   foreach (const Jvm::Class& type, argTypes) {
     signature << type.signature();
   }


[2/3] mesos git commit: Fixed a typo in an example framework.

Posted by ji...@apache.org.
Fixed a typo in an example framework.

Review: https://reviews.apache.org/r/42765/


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/1aeed335
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/1aeed335
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/1aeed335

Branch: refs/heads/master
Commit: 1aeed335a8707d37bec5eacfc55fd87c32348bd8
Parents: 0f493b5
Author: Neil Conway <ne...@gmail.com>
Authored: Mon Jan 25 16:52:10 2016 -0800
Committer: Jie Yu <yu...@gmail.com>
Committed: Mon Jan 25 16:52:10 2016 -0800

----------------------------------------------------------------------
 src/examples/load_generator_framework.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/1aeed335/src/examples/load_generator_framework.cpp
----------------------------------------------------------------------
diff --git a/src/examples/load_generator_framework.cpp b/src/examples/load_generator_framework.cpp
index d84e36a..7d64b66 100644
--- a/src/examples/load_generator_framework.cpp
+++ b/src/examples/load_generator_framework.cpp
@@ -352,7 +352,7 @@ int main(int argc, char** argv)
         &scheduler, framework, flags.master.get());
   }
 
-  int status = driver->run() == DRIVER_STOPPED ? EXIT_SUCCESS : EXIT_SUCCESS;
+  int status = driver->run() == DRIVER_STOPPED ? EXIT_SUCCESS : EXIT_FAILURE;
 
   // Ensure that the driver process terminates.
   driver->stop();