You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ah...@apache.org on 2020/04/07 12:43:41 UTC

[commons-numbers] 09/09: PMD: Allow certain violations in Fraction/BigFraction

This is an automated email from the ASF dual-hosted git repository.

aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git

commit 233223542e392be0055edddfe7bcc54f5e49300f
Author: aherbert <ah...@apache.org>
AuthorDate: Tue Apr 7 13:40:09 2020 +0100

    PMD: Allow certain violations in Fraction/BigFraction
    
    Allow field ZERO and ONE to match method name in Fraction.
    
    Allow GodClass and ExcessiveMethodLength for BigFraction.
---
 src/main/resources/pmd/pmd-ruleset.xml | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/src/main/resources/pmd/pmd-ruleset.xml b/src/main/resources/pmd/pmd-ruleset.xml
index 5ee62ef..7d51f4a 100644
--- a/src/main/resources/pmd/pmd-ruleset.xml
+++ b/src/main/resources/pmd/pmd-ruleset.xml
@@ -109,7 +109,8 @@
   <rule ref="category/java/design.xml/GodClass">
     <properties>
       <property name="violationSuppressXPath"
-        value="//ClassOrInterfaceType[@Image='Fraction']"/>
+        value="//ClassOrInterfaceType[@Image='Fraction'
+               or @Image='BigFraction']"/>
     </properties>
   </rule>
 
@@ -127,7 +128,9 @@
   <rule ref="category/java/errorprone.xml/AvoidFieldNameMatchingMethodName">
     <properties>
       <property name="violationSuppressXPath"
-        value="//ClassOrInterfaceType[@Image='Complex']"/>
+        value="//ClassOrInterfaceType[@Image='Complex'
+               or @Image='Fraction'
+               or @Image='BigFraction']"/>
     </properties>
   </rule>
 
@@ -135,7 +138,8 @@
   <rule ref="category/java/design.xml/ExcessiveMethodLength">
     <properties>
       <property name="violationSuppressXPath"
-        value="//ClassOrInterfaceType[@Image='Complex']"/>
+        value="//ClassOrInterfaceType[@Image='Complex'
+               or @Image='BigFraction']"/>
     </properties>
   </rule>