You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/11/11 03:36:28 UTC

[GitHub] [pulsar-client-go] cckellogg opened a new pull request #86: Simplify and refactor parts of the single topic consumer.

cckellogg opened a new pull request #86: Simplify and refactor parts of  the single topic consumer.
URL: https://github.com/apache/pulsar-client-go/pull/86
 
 
   ### Motivation
   
   This simplifies the consumer api and refactors the internals of how a single consumer works. I think we should start with a simple api and get all of that functionality working and well tested before adding more complexity and features.
   
   The goal of the refactor was to simplify the code and make more it more readable. The main idea is that each partition consumer will run two go routines. On go routine will be an event loop to process events from the broker and connection events. The second go routine will be a message dispatcher that will manage its internal queue. This dispatcher go routine will output messages on a shared message channel and while its internal queue is drained it will ask the broker for more messages.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services