[GitHub] [ozone] smitajoshi12 commented on a diff in pull request #5311: HDDS-9303. Ozone Manager : Display leader information in tanle format and highlight current node.

["smitajoshi12 (via GitHub)" <gi...@apache.org>]

smitajoshi12 commented on code in PR #5311:
URL: https://github.com/apache/ozone/pull/5311#discussion_r1332459594


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java:
##########
@@ -2956,16 +2956,17 @@ public String getRatisRoles() {
         leaderId = omRatisServer.getLeader();
         if (leaderId == null) {
           LOG.error("No leader found");
-          return "Exception: Not a leader";
+          return Collections.emptyList();
         }
         serviceList = getServiceList();
       } catch (IOException e) {
         LOG.error("IO-Exception Occurred", e);
-        return "Exception: " + e;
+        return Collections.emptyList();
       }
       return OmUtils.format(serviceList, port, leaderId.getId().toString());
-    } else {
-      return "Ratis-Disabled";
+    }

Review Comment:
   Done Formatting.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org