[GitHub] [trafficserver] ywkaras commented on a change in pull request #6720: MgmtConverter - extend load/store API to pass HttpSM.

[GitBox <gi...@apache.org>]

ywkaras commented on a change in pull request #6720:
URL: https://github.com/apache/trafficserver/pull/6720#discussion_r420300361



##########
File path: mgmt/MgmtDefs.h
##########
@@ -72,71 +73,76 @@ struct MgmtConverter {
    * This is passed a @c void* which is a pointer to the member in the configuration instance.
    * This function must return a @c MgmtInt converted from that value.
    */
-  MgmtInt (*load_int)(const void *) = nullptr;
+  MgmtInt (*load_int)(const HttpSM *, const void *) = nullptr;
 
   /** Store a @c MgmtInt into a native type.
    *
    * This function is passed a @c void* which is a pointer to the member in the configuration
    * instance and a @c MgmtInt. The member should be updated to correspond to the @c MgmtInt value.
    */
-  void (*store_int)(void *, MgmtInt) = nullptr;
+  void (*store_int)(HttpSM *, void *, MgmtInt) = nullptr;

Review comment:
       Hmm the store puts the value in void *, so why would this change the state machine object?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org