[GitHub] trafficserver pull request #947: TS-4796 Change UnixNetHandler to always bub...

[oknet <gi...@git.apache.org>]

Github user oknet commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/947#discussion_r77499140
  
    --- Diff: iocore/net/UnixNet.cc ---
    @@ -542,7 +555,14 @@ NetHandler::mainNetEvent(int event, Event *e)
           close_UnixNetVConnection(vc, trigger_event->ethread);
         else if (vc->write.enabled && vc->write.triggered)
           write_to_net(this, vc, trigger_event->ethread);
    -    else if (!vc->write.enabled) {
    +    else if (vc->write.error) {
    +      int err = 0, errlen = sizeof(int);
    +      if (getsockopt(vc->con.fd, SOL_SOCKET, SO_ERROR, &err, (socklen_t *)&errlen) == -1) {
    +        err = errno;
    +      }
    +      if (err != EAGAIN && err != EINTR)
    +        vc->writeSignalError(this, err);
    +    } else if (!vc->write.enabled) {
    --- End diff --
    
    suggest code: 
    ```
        else {
          if (vc->write.error) {
          ...
            if (err && err != EAGAIN && err != EINTR)
              vc->writeSignalError(this, err);
            else
              vc->write.error = 0;
          }
          if (!vc->write.enabled) {
          ...
          }
        }
    ```
    the same to READ.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---