[PR] [ZEPPELIN-5942] Adds a null check to recoveryStorage [zeppelin]

["billhu0 (via GitHub)" <gi...@apache.org>]

billhu0 opened a new pull request, #4681:
URL: https://github.com/apache/zeppelin/pull/4681

   ### What is this PR for?
   
   This PR adds a null to the argument `recoveryStorage` in the constructor of `InterpreterLauncher`. Specifically, if the argument is null when `zeppelin.recovery.storage.class` is not `org.apache.zeppelin.interpreter.recovery.NullRecoveryStorage`, an `IllegalArgumentException` will be thrown.
   
   ### What type of PR is it?
   
   Bug Fix
   
   ### What is the Jira issue?
   
   * https://issues.apache.org/jira/browse/ZEPPELIN-5942
   
   ### How should this be tested?
   
   (1) Set `zeppelin.recovery.storage.class` to `org.apache.zeppelin.interpreter.recovery.FileSystemRecoveryStorage `
   (2) Run test: `org.apache.zeppelin.interpreter.launcher.StandardInterpreterLauncherTest#testLauncher`
   The test will lead to an `IllegalArgumentException`, instead of a `NullPointerException` without any message.
   
   ### Questions:
   
   * Does the license files need to update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? Yes. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ZEPPELIN-5942] Adds a null check to recoveryStorage [zeppelin]

["billhu0 (via GitHub)" <gi...@apache.org>]

billhu0 closed pull request #4681: [ZEPPELIN-5942] Adds a null check to recoveryStorage
URL: https://github.com/apache/zeppelin/pull/4681


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org