You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Kevin Wilfong (JIRA)" <ji...@apache.org> on 2012/10/12 20:27:03 UTC
[jira] [Created] (HIVE-3573) Wrap logic introduced in HIVE-3268 in
a config
Kevin Wilfong created HIVE-3573:
-----------------------------------
Summary: Wrap logic introduced in HIVE-3268 in a config
Key: HIVE-3573
URL: https://issues.apache.org/jira/browse/HIVE-3573
Project: Hive
Issue Type: Improvement
Components: Query Processor
Affects Versions: 0.10.0
Reporter: Kevin Wilfong
Assignee: Namit Jain
This patch introduces some code which can fundamentally break distribute/order/cluster/sort by if there is a bug (as was found). We should add a config around this code so administrators can quickly turn it off if needed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3573) Revert HIVE-3268
Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475284#comment-13475284 ]
Kevin Wilfong commented on HIVE-3573:
-------------------------------------
If you plan to remove the config once the bug is fixed, we'd probably be better off just reverting it.
> Revert HIVE-3268
> ----------------
>
> Key: HIVE-3573
> URL: https://issues.apache.org/jira/browse/HIVE-3573
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Affects Versions: 0.10.0
> Reporter: Kevin Wilfong
> Assignee: Namit Jain
> Attachments: hive.3573.1.patch
>
>
> This patch introduces some code which can breaks distribute/order/cluster/sort by. We should revert this code until it can be fixed (HIVE-3572).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3573) Revert HIVE-3268
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-3573:
-----------------------------
Attachment: hive.3573.2.patch
> Revert HIVE-3268
> ----------------
>
> Key: HIVE-3573
> URL: https://issues.apache.org/jira/browse/HIVE-3573
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Affects Versions: 0.10.0
> Reporter: Kevin Wilfong
> Assignee: Namit Jain
> Attachments: hive.3573.1.patch, hive.3573.2.patch
>
>
> This patch introduces some code which can breaks distribute/order/cluster/sort by. We should revert this code until it can be fixed (HIVE-3572).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3573) Revert HIVE-3268
Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Wilfong updated HIVE-3573:
--------------------------------
Description: This patch introduces some code which can breaks distribute/order/cluster/sort by. We should revert this code until it can be fixed (HIVE-3572). (was: This patch introduces some code which can fundamentally break distribute/order/cluster/sort by if there is a bug (as was found). We should add a config around this code so administrators can quickly turn it off if needed.)
> Revert HIVE-3268
> ----------------
>
> Key: HIVE-3573
> URL: https://issues.apache.org/jira/browse/HIVE-3573
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Affects Versions: 0.10.0
> Reporter: Kevin Wilfong
> Assignee: Namit Jain
> Attachments: hive.3573.1.patch
>
>
> This patch introduces some code which can breaks distribute/order/cluster/sort by. We should revert this code until it can be fixed (HIVE-3572).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3573) Wrap logic introduced in HIVE-3268 in
a config
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-3573:
-----------------------------
Attachment: hive.3573.1.patch
> Wrap logic introduced in HIVE-3268 in a config
> ----------------------------------------------
>
> Key: HIVE-3573
> URL: https://issues.apache.org/jira/browse/HIVE-3573
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Affects Versions: 0.10.0
> Reporter: Kevin Wilfong
> Assignee: Namit Jain
> Attachments: hive.3573.1.patch
>
>
> This patch introduces some code which can fundamentally break distribute/order/cluster/sort by if there is a bug (as was found). We should add a config around this code so administrators can quickly turn it off if needed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3573) Revert HIVE-3268
Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Wilfong updated HIVE-3573:
--------------------------------
Summary: Revert HIVE-3268 (was: Wrap logic introduced in HIVE-3268 in a config)
> Revert HIVE-3268
> ----------------
>
> Key: HIVE-3573
> URL: https://issues.apache.org/jira/browse/HIVE-3573
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Affects Versions: 0.10.0
> Reporter: Kevin Wilfong
> Assignee: Namit Jain
> Attachments: hive.3573.1.patch
>
>
> This patch introduces some code which can fundamentally break distribute/order/cluster/sort by if there is a bug (as was found). We should add a config around this code so administrators can quickly turn it off if needed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3573) Revert HIVE-3268
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-3573:
-----------------------------
Status: Patch Available (was: Open)
> Revert HIVE-3268
> ----------------
>
> Key: HIVE-3573
> URL: https://issues.apache.org/jira/browse/HIVE-3573
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Affects Versions: 0.10.0
> Reporter: Kevin Wilfong
> Assignee: Namit Jain
> Attachments: hive.3573.1.patch, hive.3573.2.patch
>
>
> This patch introduces some code which can breaks distribute/order/cluster/sort by. We should revert this code until it can be fixed (HIVE-3572).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3573) Revert HIVE-3268
Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Wilfong updated HIVE-3573:
--------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Revert HIVE-3268
> ----------------
>
> Key: HIVE-3573
> URL: https://issues.apache.org/jira/browse/HIVE-3573
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Affects Versions: 0.10.0
> Reporter: Kevin Wilfong
> Assignee: Namit Jain
> Attachments: hive.3573.1.patch, hive.3573.2.patch
>
>
> This patch introduces some code which can breaks distribute/order/cluster/sort by. We should revert this code until it can be fixed (HIVE-3572).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3573) Wrap logic introduced in HIVE-3268
in a config
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475277#comment-13475277 ]
Namit Jain commented on HIVE-3573:
----------------------------------
https://reviews.facebook.net/D6015
> Wrap logic introduced in HIVE-3268 in a config
> ----------------------------------------------
>
> Key: HIVE-3573
> URL: https://issues.apache.org/jira/browse/HIVE-3573
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Affects Versions: 0.10.0
> Reporter: Kevin Wilfong
> Assignee: Namit Jain
>
> This patch introduces some code which can fundamentally break distribute/order/cluster/sort by if there is a bug (as was found). We should add a config around this code so administrators can quickly turn it off if needed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3573) Revert HIVE-3268
Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475422#comment-13475422 ]
Kevin Wilfong commented on HIVE-3573:
-------------------------------------
+1 Thanks Namit
> Revert HIVE-3268
> ----------------
>
> Key: HIVE-3573
> URL: https://issues.apache.org/jira/browse/HIVE-3573
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Affects Versions: 0.10.0
> Reporter: Kevin Wilfong
> Assignee: Namit Jain
> Attachments: hive.3573.1.patch, hive.3573.2.patch
>
>
> This patch introduces some code which can breaks distribute/order/cluster/sort by. We should revert this code until it can be fixed (HIVE-3572).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3573) Revert HIVE-3268
Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475746#comment-13475746 ]
Kevin Wilfong commented on HIVE-3573:
-------------------------------------
Committed. Thanks Namit.
> Revert HIVE-3268
> ----------------
>
> Key: HIVE-3573
> URL: https://issues.apache.org/jira/browse/HIVE-3573
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Affects Versions: 0.10.0
> Reporter: Kevin Wilfong
> Assignee: Namit Jain
> Attachments: hive.3573.1.patch, hive.3573.2.patch
>
>
> This patch introduces some code which can breaks distribute/order/cluster/sort by. We should revert this code until it can be fixed (HIVE-3572).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3573) Revert HIVE-3268
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475834#comment-13475834 ]
Hudson commented on HIVE-3573:
------------------------------
Integrated in Hive-trunk-h0.21 #1737 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1737/])
HIVE-3573. Revert HIVE-3268. (njain via kevinwilfong) (Revision 1397994)
Result = FAILURE
kevinwilfong : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1397994
Files :
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/QBParseInfo.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
* /hive/trunk/ql/src/test/queries/clientnegative/expr_clusterby1.q
* /hive/trunk/ql/src/test/queries/clientnegative/expr_distributeby1.q
* /hive/trunk/ql/src/test/queries/clientnegative/expr_distributeby_sortby_1.q
* /hive/trunk/ql/src/test/queries/clientnegative/expr_orderby1.q
* /hive/trunk/ql/src/test/queries/clientnegative/expr_sortby1.q
* /hive/trunk/ql/src/test/results/clientnegative/expr_clusterby1.q.out
* /hive/trunk/ql/src/test/results/clientnegative/expr_distributeby1.q.out
* /hive/trunk/ql/src/test/results/clientnegative/expr_distributeby_sortby_1.q.out
* /hive/trunk/ql/src/test/results/clientnegative/expr_orderby1.q.out
* /hive/trunk/ql/src/test/results/clientnegative/expr_sortby1.q.out
> Revert HIVE-3268
> ----------------
>
> Key: HIVE-3573
> URL: https://issues.apache.org/jira/browse/HIVE-3573
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Affects Versions: 0.10.0
> Reporter: Kevin Wilfong
> Assignee: Namit Jain
> Attachments: hive.3573.1.patch, hive.3573.2.patch
>
>
> This patch introduces some code which can breaks distribute/order/cluster/sort by. We should revert this code until it can be fixed (HIVE-3572).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira