[GitHub] [spark] gengliangwang commented on a change in pull request #35797: [WIP][SPARK-38490][SQL][INFRA] Add Github action test job for ANSI SQL mode

[GitBox <gi...@apache.org>]

gengliangwang commented on a change in pull request #35797:
URL: https://github.com/apache/spark/pull/35797#discussion_r823356873



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2706,7 +2706,7 @@ object SQLConf {
       "standard directly, but their behaviors align with ANSI SQL's style")
     .version("3.0.0")
     .booleanConf
-    .createWithDefault(false)
+    .createWithDefault(sys.env.get("SPARK_ANSI_SQL_MODE").contains("true"))

Review comment:
       The result type of `sys.env.get("SPARK_ANSI_SQL_MODE")` is Option[String]. It is totally fine here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org