[GitHub] [geode] ezoerner commented on a change in pull request #7340: GEODE-9998: upgrade Jedis client to 4.1.1

[GitBox <gi...@apache.org>]

ezoerner commented on a change in pull request #7340:
URL: https://github.com/apache/geode/pull/7340#discussion_r808180787



##########
File path: geode-for-redis/src/integrationTest/java/org/apache/geode/redis/internal/commands/executor/sortedset/AbstractZRevRangeByScoreIntegrationTest.java
##########
@@ -216,11 +216,22 @@ public void shouldReturnRange_givenLeftParenOnlyForMinOrMax() {
   public void shouldReturnRange_boundedByLimit() {
     createZSetRangeTestMap();
 
-    assertThat(jedis.zrevrangeByScore(KEY, "10", "0", 0, 2))
+    /*
+     * Fails in Jedis 4.1.1 for both Geode and Native Redis, so must be a Jedis bug
+     * TODO submit GitHub issue for this

Review comment:
       It's not entirely clear to me that the localSocketAddress is actually necessary here. I think this may have been part of the thread name for debugging purposes or for trivial reasons. So I will delete the commented out code, but only file a bug if someone thinks it is necessary. The test works fine without it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org