You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by ic...@apache.org on 2023/05/02 10:26:08 UTC

svn commit: r1909565 - /httpd/httpd/trunk/test/modules/http2/test_200_header_invalid.py

Author: icing
Date: Tue May  2 10:26:08 2023
New Revision: 1909565

URL: http://svn.apache.org/viewvc?rev=1909565&view=rev
Log:
test_h2_200_16, check that we have at least nghttp2 v1.45.0


Modified:
    httpd/httpd/trunk/test/modules/http2/test_200_header_invalid.py

Modified: httpd/httpd/trunk/test/modules/http2/test_200_header_invalid.py
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/test/modules/http2/test_200_header_invalid.py?rev=1909565&r1=1909564&r2=1909565&view=diff
==============================================================================
--- httpd/httpd/trunk/test/modules/http2/test_200_header_invalid.py (original)
+++ httpd/httpd/trunk/test/modules/http2/test_200_header_invalid.py Tue May  2 10:26:08 2023
@@ -165,6 +165,8 @@ class TestInvalidHeaders:
 
     # invalid chars in method
     def test_h2_200_16(self, env):
+        if not env.h2load_is_at_least('1.45.0'):
+            pytest.skip(f'nhttp2 version too old')
         conf = H2Conf(env)
         conf.add_vhost_cgi()
         conf.install()
@@ -173,12 +175,10 @@ class TestInvalidHeaders:
         opt = ["-H:method: GET /hello.py"]
         r = env.nghttp().get(url, options=opt)
         assert r.exit_code == 0, r
-        # nghttp version >= 1.45.0 check pseudo headers and RST streams,
-        # which means we see no response.
+        assert r.response is None
         if r.response is not None:
             assert r.response["status"] == 400
         url = env.mkurl("https", "cgi", "/proxy/hello.py")
         r = env.nghttp().get(url, options=opt)
         assert r.exit_code == 0, r
-        if r.response is not None:
-            assert r.response["status"] == 400
+        assert r.response is None