You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by "Jackie-Jiang (via GitHub)" <gi...@apache.org> on 2024/12/13 01:34:49 UTC

[I] Ask about ExternalView behavior change from 1.3.1 to 1.4.2 [helix]

Jackie-Jiang opened a new issue, #2982:
URL: https://github.com/apache/helix/issues/2982

   I was trying to upgrade Helix version from 1.3.1 to 1.4.2 in Apache Pinot, and found a lot of tests failing. I think I've located the issue to when ExternalView is created, and I want to confirm if this is an intended behavior change.
   
   In 1.3.1, ExternalView is created when the resource is added, even if there is no partition within the resource.
   Is this behavior changed? In 1.4.2, is ExternalView created when the first partition being added?
   
   Really appreciate some help here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org


Re: [I] Ask about ExternalView behavior change from 1.3.1 to 1.4.2 [helix]

Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on issue #2982:
URL: https://github.com/apache/helix/issues/2982#issuecomment-2540597045

   I think this line causes this behavior change: https://github.com/apache/helix/pull/2782/files#diff-321cf13f9b2ecee61b329273b373b7cac7ec1b2e4b99b66c3d045847f2c1f040R94


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org


Re: [I] Ask about ExternalView behavior change from 1.3.1 to 1.4.2 [helix]

Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang closed issue #2982: Ask about ExternalView behavior change from 1.3.1 to 1.4.2
URL: https://github.com/apache/helix/issues/2982


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org


Re: [I] Ask about ExternalView behavior change from 1.3.1 to 1.4.2 [helix]

Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on issue #2982:
URL: https://github.com/apache/helix/issues/2982#issuecomment-2588717889

   Closing this one since it is the same as #2850 and the change has been reverted


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org