You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/22 14:24:44 UTC

[GitHub] [incubator-shardingsphere] kimmking opened a new pull request #4891: Polish ApolloProperty

kimmking opened a new pull request #4891: Polish ApolloProperty
URL: https://github.com/apache/incubator-shardingsphere/pull/4891
 
 
   
   Changes proposed in this pull request:
   - Polish ApolloProperty
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4891: Polish ApolloProperty

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4891: Polish ApolloProperty
URL: https://github.com/apache/incubator-shardingsphere/pull/4891#issuecomment-602219725
 
 
   ## Pull Request Test Coverage Report for [Build 2210](https://coveralls.io/builds/29532712)
   
   * **1** of **1**   **(100.0%)**  changed or added relevant line in **1** file are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage increased (+**0.07%**) to **58.246%**
   
   ---
   
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29532712/badge)](https://coveralls.io/builds/29532712) |
   | :-- | --: |
   | Change from base [Build 1143](https://coveralls.io/builds/29530464): |  0.07% |
   | Covered Lines: | 11884 |
   | Relevant Lines: | 20403 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4891: Polish ApolloProperty

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4891: Polish ApolloProperty
URL: https://github.com/apache/incubator-shardingsphere/pull/4891#issuecomment-602219104
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4891?src=pr&el=h1) Report
   > Merging [#4891](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4891?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/dc04259bbdb5f26da8d8676333185925d9184493&el=desc) will **decrease** coverage by `0.02%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4891/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4891?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4891      +/-   ##
   ============================================
   - Coverage     54.68%   54.65%   -0.03%     
     Complexity      436      436              
   ============================================
     Files          1138     1138              
     Lines         20396    20403       +7     
     Branches       3748     3750       +2     
   ============================================
   - Hits          11153    11152       -1     
   - Misses         8539     8547       +8     
     Partials        704      704              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4891?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...chestration/center/instance/ApolloPropertyKey.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4891/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci1hcG9sbG8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL29yY2hlc3RyYXRpb24vY2VudGVyL2luc3RhbmNlL0Fwb2xsb1Byb3BlcnR5S2V5LmphdmE=) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...org/apache/shardingsphere/core/rule/TableRule.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4891/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9ydWxlL1RhYmxlUnVsZS5qYXZh) | `85.26% <0.00%> (-0.16%)` | `1.00% <0.00%> (ø%)` | |
   | [.../core/metadata/ShardingTableMetaDataDecorator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4891/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9tZXRhZGF0YS9TaGFyZGluZ1RhYmxlTWV0YURhdGFEZWNvcmF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...r/binder/metadata/column/ColumnMetaDataLoader.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4891/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWJpbmRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9iaW5kZXIvbWV0YWRhdGEvY29sdW1uL0NvbHVtbk1ldGFEYXRhTG9hZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4891?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4891?src=pr&el=footer). Last update [d0f7a7b...9906c84](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4891?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4891: Polish ApolloProperty

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4891: Polish ApolloProperty
URL: https://github.com/apache/incubator-shardingsphere/pull/4891#issuecomment-602219725
 
 
   ## Pull Request Test Coverage Report for [Build 10482](https://coveralls.io/builds/29532688)
   
   * **1** of **1**   **(100.0%)**  changed or added relevant line in **1** file are covered.
   * **3** unchanged lines in **1** file lost coverage.
   * Overall coverage decreased (**-0.005%**) to **58.168%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-registrycenter/src/main/java/org/apache/shardingsphere/orchestration/core/registrycenter/util/IpUtils.java](https://coveralls.io/builds/29532688/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-registrycenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fregistrycenter%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
   <!-- | **Total:** | **3** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29532688/badge)](https://coveralls.io/builds/29532688) |
   | :-- | --: |
   | Change from base [Build 1143](https://coveralls.io/builds/29530464): |  -0.005% |
   | Covered Lines: | 11868 |
   | Relevant Lines: | 20403 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4891: Polish ApolloProperty

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #4891: Polish ApolloProperty
URL: https://github.com/apache/incubator-shardingsphere/pull/4891
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services