You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/04/25 07:06:14 UTC

[GitHub] [incubator-superset] elukey opened a new pull request #7377: druid connector: avoid using 'dimensions' for scan queries

elukey opened a new pull request #7377: druid connector: avoid using 'dimensions' for scan queries
URL: https://github.com/apache/incubator-superset/pull/7377
 
 
   After the following PyDruid change (contained in version 0.5.2)
   the Superset Histogram charts rendered with Druid data are
   broken:
   
   https://github.com/druid-io/pydruid/commit/0a59a70829bafc85951d05c49efb571f9f51e557
   
   Issue: #7368
   
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   
   Histogram charts worked in Superset 0.31 but not in 0.32. The culprit seems to be the following pydruid change (contained in 0.5.2, that is listed among the Superset 0.32's requirements):
   https://github.com/druid-io/pydruid/commit/0a59a70829bafc85951d05c49efb571f9f51e557
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   Rendering a histogram chart from Druid data. 
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org