You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org> on 2011/10/18 20:13:12 UTC
[jira] [Commented] (SHINDIG-1643) Gadget Admin Code Does Not Take
Into Account Ports In Gadget URLs
[ https://issues.apache.org/jira/browse/SHINDIG-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129899#comment-13129899 ]
jiraposter@reviews.apache.org commented on SHINDIG-1643:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2425/
-----------------------------------------------------------
Review request for shindig and Dan Dumont.
Summary
-------
If there is a gadget in the admin store, for example http://foo.com/gadget.xml and we try to render http://foo.com:80/gadget.xml shindig does not think http://foo.com:80/gadget.xml is the same as http://foo.com/gadget.xml are the same gadget so it does not think the gadget should be allowed to render.
This addresses bug SHINDIG-1643.
https://issues.apache.org/jira/browse/SHINDIG-1643
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/ContainerAdminData.java 1185758
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/BasicGadgetAdminStoreTest.java 1185758
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/ContainerAdminDataTest.java 1185758
Diff: https://reviews.apache.org/r/2425/diff
Testing
-------
Updated unit tests to test new functionality
Thanks,
Ryan
> Gadget Admin Code Does Not Take Into Account Ports In Gadget URLs
> -----------------------------------------------------------------
>
> Key: SHINDIG-1643
> URL: https://issues.apache.org/jira/browse/SHINDIG-1643
> Project: Shindig
> Issue Type: Bug
> Reporter: Ryan Baxter
> Fix For: 3.0.0
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> If there is a gadget in the admin store, for example http://foo.com/gadget.xml and we try to render http://foo.com:80/gadget.xml shindig does not think http://foo.com:80/gadget.xml is the same as http://foo.com/gadget.xml are the same gadget so it does not think the gadget should be allowed to render.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira