You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2018/03/13 02:14:41 UTC
[kudu-CR] WIP: KUDU-2335. Do not collect tablet report when queue is closed
Hello Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/9599
to review the following change.
Change subject: WIP: KUDU-2335. Do not collect tablet report when queue is closed
......................................................................
WIP: KUDU-2335. Do not collect tablet report when queue is closed
Needs tests.
Change-Id: I93cccbc7c76c5920485e85c68f131e141146005e
---
M src/kudu/consensus/consensus_queue.cc
M src/kudu/consensus/consensus_queue.h
M src/kudu/consensus/raft_consensus.cc
3 files changed, 16 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/99/9599/1
--
To view, visit http://gerrit.cloudera.org:8080/9599
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I93cccbc7c76c5920485e85c68f131e141146005e
Gerrit-Change-Number: 9599
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR] WIP: KUDU-2335. Do not collect tablet report when queue is closed
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9599 )
Change subject: WIP: KUDU-2335. Do not collect tablet report when queue is closed
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/9599/1/src/kudu/consensus/consensus_queue.cc
File src/kudu/consensus/consensus_queue.cc:
http://gerrit.cloudera.org:8080/#/c/9599/1/src/kudu/consensus/consensus_queue.cc@311
PS1, Line 311: }
Does it make sense to add DASSERT(!reports.empty()) to catch inconsistencies when even the peer itself is not in the result map?
http://gerrit.cloudera.org:8080/#/c/9599/1/src/kudu/consensus/raft_consensus.cc
File src/kudu/consensus/raft_consensus.cc:
http://gerrit.cloudera.org:8080/#/c/9599/1/src/kudu/consensus/raft_consensus.cc@2353
PS1, Line 2353: if (PREDICT_FALSE(!s.ok())) {
: // We will not be able to determine tablet health if the queue is closed.
: if (!s.IsIllegalState()) return s;
nit: maybe, joins this two conditions under a single 'if' clause?
--
To view, visit http://gerrit.cloudera.org:8080/9599
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93cccbc7c76c5920485e85c68f131e141146005e
Gerrit-Change-Number: 9599
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 14 Mar 2018 20:42:08 +0000
Gerrit-HasComments: Yes