You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/01/12 13:38:39 UTC

[GitHub] [rocketmq] zhangjidi2016 opened a new pull request #2591: [ISSUE #2556] Lite pull consumer support message trace

zhangjidi2016 opened a new pull request #2591:
URL: https://github.com/apache/rocketmq/pull/2591

**Make sure set the target branch to `develop`**

## What is the purpose of the change

Lite pull consumer support message trace and optimize the clienthost in the message trace

## Brief changelog

XX

## Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.

- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls edited a comment on pull request #2591: [ISSUE #2556] Lite pull consumer support message trace

Posted by GitBox <gi...@apache.org>.

coveralls edited a comment on pull request #2591:
URL: https://github.com/apache/rocketmq/pull/2591#issuecomment-759141628


   
   [![Coverage Status](https://coveralls.io/builds/36288969/badge)](https://coveralls.io/builds/36288969)
   
   Coverage increased (+0.004%) to 51.941% when pulling **ceac8038b0cd7f22e4d62d2a4ff812d2bc76126b on zhangjidi2016:litePullConsumer_support_trace** into **98aca7ffcbf282b2885ad4b9c433927a5ac0e78b on apache:develop**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] codecov-io edited a comment on pull request #2591: [ISSUE #2556] Lite pull consumer support message trace

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #2591:
URL: https://github.com/apache/rocketmq/pull/2591#issuecomment-759148166


   # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2591?src=pr&el=h1) Report
   > Merging [#2591](https://codecov.io/gh/apache/rocketmq/pull/2591?src=pr&el=desc) (d8361fb) into [develop](https://codecov.io/gh/apache/rocketmq/commit/98aca7ffcbf282b2885ad4b9c433927a5ac0e78b?el=desc) (98aca7f) will **decrease** coverage by `0.18%`.
   > The diff coverage is `43.75%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq/pull/2591/graphs/tree.svg?width=650&height=150&src=pr&token=4w0sxP1wZv)](https://codecov.io/gh/apache/rocketmq/pull/2591?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             develop    #2591      +/-   ##
   =============================================
   - Coverage      46.34%   46.15%   -0.19%     
   + Complexity      4356     4348       -8     
   =============================================
     Files            547      547              
     Lines          36247    36299      +52     
     Branches        4808     4814       +6     
   =============================================
   - Hits           16797    16755      -42     
   - Misses         17378    17458      +80     
   - Partials        2072     2086      +14     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/2591?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ent/impl/consumer/DefaultLitePullConsumerImpl.java](https://codecov.io/gh/apache/rocketmq/pull/2591/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9EZWZhdWx0TGl0ZVB1bGxDb25zdW1lckltcGwuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...mq/client/trace/hook/SendMessageTraceHookImpl.java](https://codecov.io/gh/apache/rocketmq/pull/2591/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvdHJhY2UvaG9vay9TZW5kTWVzc2FnZVRyYWNlSG9va0ltcGwuamF2YQ==) | `70.73% <ø> (-0.70%)` | `4.00 <0.00> (ø)` | |
   | [...client/trace/hook/ConsumeMessageTraceHookImpl.java](https://codecov.io/gh/apache/rocketmq/pull/2591/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvdHJhY2UvaG9vay9Db25zdW1lTWVzc2FnZVRyYWNlSG9va0ltcGwuamF2YQ==) | `78.18% <80.00%> (+0.40%)` | `6.00 <0.00> (+1.00)` | |
   | [...ketmq/client/consumer/DefaultLitePullConsumer.java](https://codecov.io/gh/apache/rocketmq/pull/2591/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvY29uc3VtZXIvRGVmYXVsdExpdGVQdWxsQ29uc3VtZXIuamF2YQ==) | `74.69% <80.76%> (+1.16%)` | `59.00 <4.00> (+5.00)` | |
   | [...apache/rocketmq/client/trace/TraceDataEncoder.java](https://codecov.io/gh/apache/rocketmq/pull/2591/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvdHJhY2UvVHJhY2VEYXRhRW5jb2Rlci5qYXZh) | `63.47% <100.00%> (+1.81%)` | `10.00 <0.00> (+1.00)` | |
   | [...va/org/apache/rocketmq/client/trace/TraceView.java](https://codecov.io/gh/apache/rocketmq/pull/2591/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvdHJhY2UvVHJhY2VWaWV3LmphdmE=) | `73.13% <100.00%> (+0.40%)` | `17.00 <0.00> (ø)` | |
   | [.../broker/subscription/SubscriptionGroupManager.java](https://codecov.io/gh/apache/rocketmq/pull/2591/diff?src=pr&el=tree#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvc3Vic2NyaXB0aW9uL1N1YnNjcmlwdGlvbkdyb3VwTWFuYWdlci5qYXZh) | `54.11% <0.00%> (-16.48%)` | `8.00% <0.00%> (-3.00%)` | |
   | [...ain/java/org/apache/rocketmq/test/util/MQWait.java](https://codecov.io/gh/apache/rocketmq/pull/2591/diff?src=pr&el=tree#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC91dGlsL01RV2FpdC5qYXZh) | `43.24% <0.00%> (-16.22%)` | `3.00% <0.00%> (-1.00%)` | |
   | [...org/apache/rocketmq/common/stats/StatsItemSet.java](https://codecov.io/gh/apache/rocketmq/pull/2591/diff?src=pr&el=tree#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvU3RhdHNJdGVtU2V0LmphdmE=) | `43.28% <0.00%> (-8.96%)` | `17.00% <0.00%> (-3.00%)` | |
   | [...ketmq/client/impl/consumer/PullMessageService.java](https://codecov.io/gh/apache/rocketmq/pull/2591/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9QdWxsTWVzc2FnZVNlcnZpY2UuamF2YQ==) | `71.11% <0.00%> (-8.89%)` | `8.00% <0.00%> (-2.00%)` | |
   | ... and [27 more](https://codecov.io/gh/apache/rocketmq/pull/2591/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/2591?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2591?src=pr&el=footer). Last update [98aca7f...d8361fb](https://codecov.io/gh/apache/rocketmq/pull/2591?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls commented on pull request #2591: [ISSUE #2556] Lite pull consumer support message trace

Posted by GitBox <gi...@apache.org>.

coveralls commented on pull request #2591:
URL: https://github.com/apache/rocketmq/pull/2591#issuecomment-759141628


   
   [![Coverage Status](https://coveralls.io/builds/36280234/badge)](https://coveralls.io/builds/36280234)
   
   Coverage decreased (-0.1%) to 51.827% when pulling **d8361fb203b216b0220e02b9482e687d59faeb0b on zhangjidi2016:litePullConsumer_support_trace** into **98aca7ffcbf282b2885ad4b9c433927a5ac0e78b on apache:develop**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] zhangjidi2016 closed pull request #2591: [ISSUE #2556] Lite pull consumer support message trace

Posted by GitBox <gi...@apache.org>.

zhangjidi2016 closed pull request #2591:
URL: https://github.com/apache/rocketmq/pull/2591


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] codecov-io commented on pull request #2591: [ISSUE #2556] Lite pull consumer support message trace

Posted by GitBox <gi...@apache.org>.

codecov-io commented on pull request #2591:
URL: https://github.com/apache/rocketmq/pull/2591#issuecomment-759148166


   # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2591?src=pr&el=h1) Report
   > Merging [#2591](https://codecov.io/gh/apache/rocketmq/pull/2591?src=pr&el=desc) (d8361fb) into [develop](https://codecov.io/gh/apache/rocketmq/commit/98aca7ffcbf282b2885ad4b9c433927a5ac0e78b?el=desc) (98aca7f) will **decrease** coverage by `0.18%`.
   > The diff coverage is `43.75%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq/pull/2591/graphs/tree.svg?width=650&height=150&src=pr&token=4w0sxP1wZv)](https://codecov.io/gh/apache/rocketmq/pull/2591?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             develop    #2591      +/-   ##
   =============================================
   - Coverage      46.34%   46.15%   -0.19%     
   + Complexity      4356     4348       -8     
   =============================================
     Files            547      547              
     Lines          36247    36299      +52     
     Branches        4808     4814       +6     
   =============================================
   - Hits           16797    16755      -42     
   - Misses         17378    17458      +80     
   - Partials        2072     2086      +14     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/2591?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ent/impl/consumer/DefaultLitePullConsumerImpl.java](https://codecov.io/gh/apache/rocketmq/pull/2591/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9EZWZhdWx0TGl0ZVB1bGxDb25zdW1lckltcGwuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...mq/client/trace/hook/SendMessageTraceHookImpl.java](https://codecov.io/gh/apache/rocketmq/pull/2591/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvdHJhY2UvaG9vay9TZW5kTWVzc2FnZVRyYWNlSG9va0ltcGwuamF2YQ==) | `70.73% <ø> (-0.70%)` | `4.00 <0.00> (ø)` | |
   | [...client/trace/hook/ConsumeMessageTraceHookImpl.java](https://codecov.io/gh/apache/rocketmq/pull/2591/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvdHJhY2UvaG9vay9Db25zdW1lTWVzc2FnZVRyYWNlSG9va0ltcGwuamF2YQ==) | `78.18% <80.00%> (+0.40%)` | `6.00 <0.00> (+1.00)` | |
   | [...ketmq/client/consumer/DefaultLitePullConsumer.java](https://codecov.io/gh/apache/rocketmq/pull/2591/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvY29uc3VtZXIvRGVmYXVsdExpdGVQdWxsQ29uc3VtZXIuamF2YQ==) | `74.69% <80.76%> (+1.16%)` | `59.00 <4.00> (+5.00)` | |
   | [...apache/rocketmq/client/trace/TraceDataEncoder.java](https://codecov.io/gh/apache/rocketmq/pull/2591/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvdHJhY2UvVHJhY2VEYXRhRW5jb2Rlci5qYXZh) | `63.47% <100.00%> (+1.81%)` | `10.00 <0.00> (+1.00)` | |
   | [...va/org/apache/rocketmq/client/trace/TraceView.java](https://codecov.io/gh/apache/rocketmq/pull/2591/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvdHJhY2UvVHJhY2VWaWV3LmphdmE=) | `73.13% <100.00%> (+0.40%)` | `17.00 <0.00> (ø)` | |
   | [.../broker/subscription/SubscriptionGroupManager.java](https://codecov.io/gh/apache/rocketmq/pull/2591/diff?src=pr&el=tree#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvc3Vic2NyaXB0aW9uL1N1YnNjcmlwdGlvbkdyb3VwTWFuYWdlci5qYXZh) | `54.11% <0.00%> (-16.48%)` | `8.00% <0.00%> (-3.00%)` | |
   | [...ain/java/org/apache/rocketmq/test/util/MQWait.java](https://codecov.io/gh/apache/rocketmq/pull/2591/diff?src=pr&el=tree#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC91dGlsL01RV2FpdC5qYXZh) | `43.24% <0.00%> (-16.22%)` | `3.00% <0.00%> (-1.00%)` | |
   | [...org/apache/rocketmq/common/stats/StatsItemSet.java](https://codecov.io/gh/apache/rocketmq/pull/2591/diff?src=pr&el=tree#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvU3RhdHNJdGVtU2V0LmphdmE=) | `43.28% <0.00%> (-8.96%)` | `17.00% <0.00%> (-3.00%)` | |
   | [...ketmq/client/impl/consumer/PullMessageService.java](https://codecov.io/gh/apache/rocketmq/pull/2591/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9QdWxsTWVzc2FnZVNlcnZpY2UuamF2YQ==) | `71.11% <0.00%> (-8.89%)` | `8.00% <0.00%> (-2.00%)` | |
   | ... and [27 more](https://codecov.io/gh/apache/rocketmq/pull/2591/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/2591?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2591?src=pr&el=footer). Last update [98aca7f...d8361fb](https://codecov.io/gh/apache/rocketmq/pull/2591?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org