You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/25 05:37:32 UTC
[GitHub] [apisix-website] juzhiyuan opened a new pull request #205: feat: sync docs & deploy
juzhiyuan opened a new pull request #205:
URL: https://github.com/apache/apisix-website/pull/205
sync docs first then deploy
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] LiteSun commented on a change in pull request #205: feat: sync docs & deploy
Posted by GitBox <gi...@apache.org>.
LiteSun commented on a change in pull request #205:
URL: https://github.com/apache/apisix-website/pull/205#discussion_r582884165
##########
File path: .github/workflows/deploy.yml
##########
@@ -9,7 +9,7 @@ on:
branches: [master]
schedule:
# Run everyday at 9:00 AM (See https://pubs.opengroup.org/onlinepubs/9699919799/utilities/crontab.html#tag_20_25_07)
Review comment:
What timezone is used here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #205: feat: sync docs & deploy
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #205:
URL: https://github.com/apache/apisix-website/pull/205#discussion_r582805951
##########
File path: sync-docs.js
##########
@@ -38,7 +39,10 @@ const replaceMDImageUrl = (project, paths) => {
.match(/\((.+?)\)/g)[0]
.replace("(", "")
.replace(")", "")
- .replaceAll("../", "");
+ .replace("../", "")
+ .replace("../", "")
+ .replace("../", "")
+ .replace("../", "");
Review comment:
it's a trick here, to replace some paths like `../../../xxxx`, `../../xxxx`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #205: feat: sync docs & deploy
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #205:
URL: https://github.com/apache/apisix-website/pull/205#discussion_r582808724
##########
File path: sync-docs.js
##########
@@ -38,7 +39,10 @@ const replaceMDImageUrl = (project, paths) => {
.match(/\((.+?)\)/g)[0]
.replace("(", "")
.replace(")", "")
- .replaceAll("../", "");
+ .replace("../", "")
+ .replace("../", "")
+ .replace("../", "")
+ .replace("../", "");
Review comment:
because replaceAll function is not available here, so I use a trick here. This JS file will get improved in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #205: feat: sync docs & deploy
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #205:
URL: https://github.com/apache/apisix-website/pull/205#discussion_r582912477
##########
File path: .github/workflows/deploy.yml
##########
@@ -9,7 +9,7 @@ on:
branches: [master]
schedule:
# Run everyday at 9:00 AM (See https://pubs.opengroup.org/onlinepubs/9699919799/utilities/crontab.html#tag_20_25_07)
Review comment:
GMT+8
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan merged pull request #205: feat: sync docs & deploy
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #205:
URL: https://github.com/apache/apisix-website/pull/205
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] Yiyiyimu commented on a change in pull request #205: feat: sync docs & deploy
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #205:
URL: https://github.com/apache/apisix-website/pull/205#discussion_r582805003
##########
File path: sync-docs.js
##########
@@ -38,7 +39,10 @@ const replaceMDImageUrl = (project, paths) => {
.match(/\((.+?)\)/g)[0]
.replace("(", "")
.replace(")", "")
- .replaceAll("../", "");
+ .replace("../", "")
+ .replace("../", "")
+ .replace("../", "")
+ .replace("../", "");
Review comment:
I noticed this change is in https://github.com/apache/apisix-website/pull/205/commits/eda04d98b37a25dbd8dab5383b7e6372256c69fc to pass CI, but I can't get what's the meaning of this 🤣
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] Yiyiyimu commented on a change in pull request #205: feat: sync docs & deploy
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #205:
URL: https://github.com/apache/apisix-website/pull/205#discussion_r582805003
##########
File path: sync-docs.js
##########
@@ -38,7 +39,10 @@ const replaceMDImageUrl = (project, paths) => {
.match(/\((.+?)\)/g)[0]
.replace("(", "")
.replace(")", "")
- .replaceAll("../", "");
+ .replace("../", "")
+ .replace("../", "")
+ .replace("../", "")
+ .replace("../", "");
Review comment:
I noticed this change is in https://github.com/apache/apisix-website/pull/205/commits/eda04d98b37a25dbd8dab5383b7e6372256c69fc to pass CI, but it seems a bit hacky and I can't get what's the meaning of this 🤣
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org