[GitHub] [airflow] kaxil commented on issue #7119: [AIRFLOW-5840] Add operator extra link to external task sensor

[GitBox <gi...@apache.org>]

kaxil commented on issue #7119: [AIRFLOW-5840] Add operator extra link to external task sensor
URL: https://github.com/apache/airflow/pull/7119#issuecomment-573232828
 
 
   > One thing I'm struggling with is how to get the `execution_delta` parameter to deserialize as a `timedelta`. Right now, it looks like it serializes to a float (as number of seconds) and doesn't get converted back on deserialization. I could manually convert it here https://github.com/apache/airflow/pull/7119/files#diff-108fa7b4349eeb1a31c07c64a952c972R52, but that seems a bit hacky to me. Looking at the `_deserialize` function here https://github.com/apache/airflow/blob/master/airflow/serialization/serialized_objects.py#L200, it seems like there is the possibility to have it marked as a `timedelta`, but I can't seem to figure out where I would do that. Do I need to add typing to the property or maybe I define `__serialized_fields` differently?
   
   We already have timedelta: https://github.com/apache/airflow/blob/master/airflow/serialization/serialized_objects.py#L222
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services